You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The use of the following variables is inconsistent, which should be documented or fixed at some point: sigil/sigla, humanReadableSigil, handle, label.
In fact they could be reduced to:
siglaHandle/siglaHandle: "nk" (for "n klein") or "fr5"
sigil/sigla: "n" or "Fr. 5 (d)"
Currently, label and humanReadableSigil (as well as sigla in the searchIndex.json files) are used for (1) whereas handle, sigil/sigla and are used for (2).
The inconsistency originates from the .json files (as stated in @vvvyyynet in #40 (comment)_): metadata-nomenclature.json uses sigla and handle correctly, whereas searchIndex.json incorrectly uses sigla for the handles. Currently this is compensated for in the frontend, introducing confusing name choices.
The use of the following variables is inconsistent, which should be documented or fixed at some point:
sigil
/sigla
,humanReadableSigil
,handle
,label
.In fact they could be reduced to:
siglaHandle
/siglaHandle
: "nk" (for "n klein") or "fr5"sigil
/sigla
: "n" or "Fr. 5 (d)"Currently,
label
andhumanReadableSigil
(as well assigla
in the searchIndex.json files) are used for (1) whereashandle
,sigil
/sigla
and are used for (2).The inconsistency originates from the .json files (as stated in @vvvyyynet in #40 (comment)_):
metadata-nomenclature.json
usessigla
andhandle
correctly, whereassearchIndex.json
incorrectly usessigla
for the handles. Currently this is compensated for in the frontend, introducing confusing name choices.Originally posted by @vvvyyynet in #40 (comment)
The text was updated successfully, but these errors were encountered: