Skip to content

Provide Military::addToSquad and possibly revise Military::removeFromSquad #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chdoc opened this issue Mar 15, 2025 · 2 comments
Closed
Assignees

Comments

@chdoc
Copy link
Member

chdoc commented Mar 15, 2025

This functionality is necessary to implement DFHack/scripts#1411 and complicated enough that it makes sense to centralize it.

@ab9rf ab9rf self-assigned this Mar 15, 2025
@ab9rf
Copy link
Member

ab9rf commented Mar 19, 2025

initial notes from static reverse engineering:

  • squads consist of histfigs. not units, so to be added to a squad a unit has to have a histfig
  • adding a histfig to a squad adds a histfig entity link of type SQUAD between the histfig and the squad
  • removing a histfig from a squad removes the SQUAD link and adds a FORMER_SQUAD link
  • i have not yet determined whether each time a histfig is removed from a squad, whether it gets a new FORMER_SQUAD link, or if there is only one such link per histfig per squad
  • adding a histfig to and removing a histfig from a squad optionally adds history events

@myk002 myk002 added this to 51.11-r2 Apr 3, 2025
@github-project-automation github-project-automation bot moved this to Todo in 51.11-r2 Apr 3, 2025
@myk002
Copy link
Member

myk002 commented Apr 4, 2025

fixed by #5363

@myk002 myk002 closed this as completed Apr 4, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in 51.11-r2 Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants