cleaning up hierarchical consistency issues#15
Open
bmcfee wants to merge 5 commits into
Open
Conversation
Author
|
Note about downcasing uppers: I'm only preserving the letter if it doesn't conflict with one already in use. Otherwise, I find a new unused letter. The exception to this is when it's an obvious typo/mistake, and it's clear what the lower should be. |
Author
|
Hitting some strange edge cases here. For example, 765/textfile2 has lowercase annotations of the form @jblsmith What should be done with these cases? EDIT: it's only two files: 762/textfile2 and 775/textfile2. |
Author
|
quoting from previous thread:
I've done this for the two tracks in question (765.2, 775.2). Everything now passes the alignment test and validates properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to issue #13.
This PR implements the following:
At some later point, #14 should replace
Zboundaries with a must-havenon-musictag.I'll update the title of this PR once the smoke clears and it's ready for review.