Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions web-app/django/VIM/apps/instruments/views/update_umil_db.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,33 @@ def delete_name(request: HttpRequest) -> JsonResponse:

instrument_id = instrument_name.instrument_id

# Retain language and label info before deletion
language_id = instrument_name.language_id
was_umil_label = instrument_name.umil_label

# Delete the name
instrument_name.delete()

# Assign new label: If the deleted name was the main/UMIL label for its instrument/language
# AND there's at least one other name for this instrument in that language,
if was_umil_label:
next_label_name = (
InstrumentName.objects.filter(
instrument_id=instrument_id, language_id=language_id
)
.order_by("pk")
.first()
)
if next_label_name:
next_label_name.umil_label = True
try:
next_label_name.save(update_fields=["umil_label"])
except Exception as e:
logger.error(
f"Could not assign new main name for instrument_id={instrument_id} "
f"language_id={language_id}: {e}"
)

# Schedule Solr reindex after commit so the deleted name is removed from search
def schedule_indexing():
try:
Expand Down
Loading