Skip to content

Commit afa4b18

Browse files
neueccneuecc
committed
AppendFormatted<T> JIT
1 parent 43d5845 commit afa4b18

File tree

4 files changed

+116
-8
lines changed

4 files changed

+116
-8
lines changed

‎src/Utf8StringInterpolation/Utf8StringInterpolation.csproj‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,24 @@
2323
<PackageReference Include="System.Memory" Version="4.5.5" />
2424
</ItemGroup>
2525

26+
<ItemGroup Condition="'$(TargetFramework)'=='netstandard2.1'">
27+
<PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" />
28+
</ItemGroup>
29+
2630
<ItemGroup>
2731
<None Include="../../Icon.png" Pack="true" PackagePath="/" />
2832
</ItemGroup>
2933

3034
<ItemGroup>
3135
<Service Include="{508349b6-6b84-4df5-91f0-309beebad82d}" />
32-
<None Update="Utf8String.AppendFormatted.tt">
36+
<None Update="Utf8StringWriter.AppendFormatted.tt">
3337
<Generator>TextTemplatingFileGenerator</Generator>
34-
<LastGenOutput>Utf8String.AppendFormatted.cs</LastGenOutput>
38+
<LastGenOutput>Utf8StringWriter.AppendFormatted.cs</LastGenOutput>
3539
</None>
36-
<Compile Update="Utf8String.AppendFormatted.cs">
40+
<Compile Update="Utf8StringWriter.AppendFormatted.cs">
3741
<DesignTime>True</DesignTime>
3842
<AutoGen>True</AutoGen>
39-
<DependentUpon>Utf8String.AppendFormatted.tt</DependentUpon>
43+
<DependentUpon>Utf8StringWriter.AppendFormatted.tt</DependentUpon>
4044
</Compile>
4145
</ItemGroup>
4246

‎src/Utf8StringInterpolation/Utf8String.AppendFormatted.cs‎ renamed to ‎src/Utf8StringInterpolation/Utf8StringWriter.AppendFormatted.cs‎

Lines changed: 81 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace Utf8StringInterpolation;
66

77
public ref partial struct Utf8StringWriter<TBufferWriter>
88
{
9-
# if true
9+
#if true
1010

1111
[MethodImpl(MethodImplOptions.AggressiveInlining)]
1212
public void AppendFormatted(bool? value, int alignment = 0, string? format = null)
@@ -1398,7 +1398,7 @@ void AppendFormattedAlignment(TimeSpan value, int alignment, string? format)
13981398
}
13991399
#endif
14001400

1401-
# if true
1401+
#if true
14021402

14031403
[MethodImpl(MethodImplOptions.AggressiveInlining)]
14041404
public void AppendFormatted(char? value, int alignment = 0, string? format = null)
@@ -1485,4 +1485,83 @@ void AppendFormattedAlignment(char value, int alignment, string? format)
14851485
}
14861486
#endif
14871487

1488+
1489+
// `if typeof(T) == typeof()` will eliminate in JIT.
1490+
public void AppendFormatted<T>(T value, int alignment = 0, string? format = null)
1491+
{
1492+
if (typeof(T) == typeof(bool))
1493+
{
1494+
AppendFormatted(Unsafe.As<T, bool>(ref value), alignment, format);
1495+
}
1496+
else if (typeof(T) == typeof(char))
1497+
{
1498+
AppendFormatted(Unsafe.As<T, char>(ref value), alignment, format);
1499+
}
1500+
#if !NET8_0_OR_GREATER
1501+
else if (typeof(T) == typeof(byte))
1502+
{
1503+
AppendFormatted(Unsafe.As<T, byte>(ref value), alignment, format);
1504+
}
1505+
else if (typeof(T) == typeof(Decimal))
1506+
{
1507+
AppendFormatted(Unsafe.As<T, Decimal>(ref value), alignment, format);
1508+
}
1509+
else if (typeof(T) == typeof(Double))
1510+
{
1511+
AppendFormatted(Unsafe.As<T, Double>(ref value), alignment, format);
1512+
}
1513+
else if (typeof(T) == typeof(Guid))
1514+
{
1515+
AppendFormatted(Unsafe.As<T, Guid>(ref value), alignment, format);
1516+
}
1517+
else if (typeof(T) == typeof(Int16))
1518+
{
1519+
AppendFormatted(Unsafe.As<T, Int16>(ref value), alignment, format);
1520+
}
1521+
else if (typeof(T) == typeof(Int32))
1522+
{
1523+
AppendFormatted(Unsafe.As<T, Int32>(ref value), alignment, format);
1524+
}
1525+
else if (typeof(T) == typeof(Int64))
1526+
{
1527+
AppendFormatted(Unsafe.As<T, Int64>(ref value), alignment, format);
1528+
}
1529+
else if (typeof(T) == typeof(SByte))
1530+
{
1531+
AppendFormatted(Unsafe.As<T, SByte>(ref value), alignment, format);
1532+
}
1533+
else if (typeof(T) == typeof(Single))
1534+
{
1535+
AppendFormatted(Unsafe.As<T, Single>(ref value), alignment, format);
1536+
}
1537+
else if (typeof(T) == typeof(UInt16))
1538+
{
1539+
AppendFormatted(Unsafe.As<T, UInt16>(ref value), alignment, format);
1540+
}
1541+
else if (typeof(T) == typeof(UInt32))
1542+
{
1543+
AppendFormatted(Unsafe.As<T, UInt32>(ref value), alignment, format);
1544+
}
1545+
else if (typeof(T) == typeof(UInt64))
1546+
{
1547+
AppendFormatted(Unsafe.As<T, UInt64>(ref value), alignment, format);
1548+
}
1549+
else if (typeof(T) == typeof(DateTime))
1550+
{
1551+
AppendFormatted(Unsafe.As<T, DateTime>(ref value), alignment, format);
1552+
}
1553+
else if (typeof(T) == typeof(DateTimeOffset))
1554+
{
1555+
AppendFormatted(Unsafe.As<T, DateTimeOffset>(ref value), alignment, format);
1556+
}
1557+
else if (typeof(T) == typeof(TimeSpan))
1558+
{
1559+
AppendFormatted(Unsafe.As<T, TimeSpan>(ref value), alignment, format);
1560+
}
1561+
#endif
1562+
else
1563+
{
1564+
AppendFormattedCore<T>(value, alignment, format);
1565+
}
1566+
}
14881567
}

‎src/Utf8StringInterpolation/Utf8String.AppendFormatted.tt‎ renamed to ‎src/Utf8StringInterpolation/Utf8StringWriter.AppendFormatted.tt‎

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ namespace Utf8StringInterpolation;
2929
public ref partial struct Utf8StringWriter<TBufferWriter>
3030
{
3131
<# foreach(var x in generateTypes) { #>
32-
<#= (x.type is not "bool" and not "char") ? "#if !NET8_0_OR_GREATER" : "# if true" #>
32+
<#= (x.type is not "bool" and not "char") ? "#if !NET8_0_OR_GREATER" : "#if true" #>
3333

3434
[MethodImpl(MethodImplOptions.AggressiveInlining)]
3535
public void AppendFormatted(<#= x.type #>? value, int alignment = 0, string? format = null)
@@ -117,4 +117,29 @@ public ref partial struct Utf8StringWriter<TBufferWriter>
117117
#endif
118118

119119
<# } #>
120+
121+
// `if typeof(T) == typeof()` will eliminate in JIT.
122+
public void AppendFormatted<T>(T value, int alignment = 0, string? format = null)
123+
{
124+
if (typeof(T) == typeof(bool))
125+
{
126+
AppendFormatted(Unsafe.As<T, bool>(ref value), alignment, format);
127+
}
128+
else if (typeof(T) == typeof(char))
129+
{
130+
AppendFormatted(Unsafe.As<T, char>(ref value), alignment, format);
131+
}
132+
#if !NET8_0_OR_GREATER
133+
<# foreach(var x in generateTypes.Where(x => x.type is not "bool" and not "char")) { #>
134+
else if (typeof(T) == typeof(<#= x.type #>))
135+
{
136+
AppendFormatted(Unsafe.As<T, <#= x.type #>>(ref value), alignment, format);
137+
}
138+
<# } #>
139+
#endif
140+
else
141+
{
142+
AppendFormattedCore<T>(value, alignment, format);
143+
}
144+
}
120145
}

‎src/Utf8StringInterpolation/Utf8StringWriter.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ public void AppendFormatted<T>(Nullable<T> value, int alignment = 0, string? for
247247
AppendFormatted(value.Value, alignment, format);
248248
}
249249

250-
public void AppendFormatted<T>(T value, int alignment = 0, string? format = null)
250+
void AppendFormattedCore<T>(T value, int alignment = 0, string? format = null)
251251
{
252252
// no alignment or add right whitespace
253253
if (alignment <= 0)

0 commit comments

Comments
 (0)