-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make VulnerabilityReference arguments mandatory #790
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
this fix will alter public API, and is therefore considered breaking change. |
i'll be working on this |
did some research.
since JSON schema was chosen as the dominant schema, the one that serves as first spec implementation, |
jkowalleck
added a commit
that referenced
this issue
Feb 25, 2025
fixes #790 Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Merged
jkowalleck
added a commit
that referenced
this issue
Feb 26, 2025
### BREAKING Changes * Fix: `model.vulnerability.VulnerabilityReference`'s properties are all mandatory ([#790](#790) via [#792](#792)) * Refactor: Rename `spdx.is_compund_expression` -> `spdx.is_expression` ([#779](#779)) * Behavior: `BomRef` affects comparison/hashing ([#754](#754) & [#780](#780)) This is only a breaking change if you relied on ordering of elements. * Behavior: streamline comparison/hashing functions ([#755](#755)) This is only a breaking change if you relied on ordering of elements. * Dependency: bump dependency `py-serializable >=2 <3`, was `>=1.1.1 <2` ([#775](#775)) This is only a breaking change if you have other packages depend on that specific version. --------- Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com> Signed-off-by: wkoot <3715211+wkoot@users.noreply.github.com> Signed-off-by: semantic-release <semantic-release@bot.local> Co-authored-by: wkoot <3715211+wkoot@users.noreply.github.com> Co-authored-by: semantic-release <semantic-release@bot.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This issue is created from this thread re: #786 (comment)
It's been noticed that
VulnerabilityReference
class in implementation has defined the attributesid
andsource
as optionalref: https://github.com/CycloneDX/cyclonedx-python-lib/blob/main/cyclonedx/model/vulnerability.py#L486...L497
but if we refer the documentation of cyclonedx
The refrences is optional but if a reference is defined id and source are mandatory, but current implementation treats these as optional
The text was updated successfully, but these errors were encountered: