Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reuse bomref-snippet #722

Closed
jkowalleck opened this issue Oct 23, 2024 · 0 comments · Fixed by #727
Closed

refactor: reuse bomref-snippet #722

jkowalleck opened this issue Oct 23, 2024 · 0 comments · Fixed by #727
Assignees
@jkowalleck

Comments

@jkowalleck
Copy link
Member

via https://github.com/CycloneDX/cyclonedx-python-lib/pull/701/files#diff-c90c501398d3d23a7a10846ec3ff03fb092a7c1a8f2fc90f79a29782892efcea

the duplicated code for bom-ref initializations in classes was extracted.

after the #701 was moved, the goal shall be:
find all these code duplications, and use the newly extracted function instead.
@jkowalleck jkowalleck self-assigned this Oct 26, 2024
@jkowalleck jkowalleck changed the title refacor: reuse bomref-snippet refactor: reuse bomref-snippet Oct 26, 2024
@jkowalleck jkowalleck mentioned this issue Oct 26, 2024
Merged
saquibsaifee pushed a commit to saquibsaifee/cyclonedx-python-lib that referenced this issue Oct 27, 2024
@jkowalleck @saquibsaifee
refactor: reuse internal helper bom_ref_from_str (CycloneDX#727)
cf1d880 
fixes CycloneDX#722

Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Saquib Saifee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkowalleck jkowalleck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: reuse internal helper bom_ref_from_str CycloneDX/cyclonedx-python-lib
1 participant
@jkowalleck