fix: regression introduced by first fix for #150

Signed-off-by: Paul Horton <[email protected]>

Author: madpah

Diff for: cyclonedx/output/schema.py

@@ -77,6 +77,9 @@ def component_supports_external_references(self) -> bool:
     def component_supports_release_notes(self) -> bool:
         return True
 
+    def external_references_supports_hashes(self) -> bool:
+        return True
+
     @abstractmethod
     def get_schema_version(self) -> str:
         raise NotImplementedError
@@ -150,6 +153,9 @@ def component_supports_mime_type_attribute(self) -> bool:
     def component_supports_release_notes(self) -> bool:
         return False
 
+    def external_references_supports_hashes(self) -> bool:
+        return False
+
     def get_schema_version(self) -> str:
         return '1.2'
 
@@ -193,6 +199,9 @@ def component_supports_author(self) -> bool:
     def component_supports_release_notes(self) -> bool:
         return False
 
+    def external_references_supports_hashes(self) -> bool:
+        return False
+
     def get_schema_version(self) -> str:
         return '1.1'
 
@@ -245,5 +254,8 @@ def component_supports_external_references(self) -> bool:
     def component_supports_release_notes(self) -> bool:
         return False
 
+    def external_references_supports_hashes(self) -> bool:
+        return False
+
     def get_schema_version(self) -> str:
         return '1.0'

Diff for: cyclonedx/output/xml.py

@@ -208,7 +208,7 @@ def _add_component_element(self, component: Component) -> ElementTree.Element:
                 if ext_ref.get_comment():
                     ElementTree.SubElement(external_reference_e, 'comment').text = ext_ref.get_comment()
 
-                if len(ext_ref.get_hashes()) > 0:
+                if self.external_references_supports_hashes() and len(ext_ref.get_hashes()) > 0:
                     Xml._add_hashes_to_element(hashes=ext_ref.get_hashes(), element=external_reference_e)
 
         # releaseNotes
@@ -476,8 +476,8 @@ def _get_vulnerability_as_xml_element_pre_1_3(self, bom_ref: str,
 
         return vulnerability_element
 
-    @staticmethod
-    def _add_external_references_to_element(ext_refs: List[ExternalReference], element: ElementTree.Element) -> None:
+    def _add_external_references_to_element(self, ext_refs: List[ExternalReference],
+                                            element: ElementTree.Element) -> None:
         ext_refs_element = ElementTree.SubElement(element, 'externalReferences')
         for external_reference in ext_refs:
             ext_ref_element = ElementTree.SubElement(
@@ -486,7 +486,7 @@ def _add_external_references_to_element(ext_refs: List[ExternalReference], eleme
             ElementTree.SubElement(ext_ref_element, 'url').text = external_reference.get_url()
             if external_reference.get_comment():
                 ElementTree.SubElement(ext_ref_element, 'comment').text = external_reference.get_comment()
-            if external_reference.get_hashes():
+            if self.external_references_supports_hashes() and external_reference.get_hashes():
                 Xml._add_hashes_to_element(hashes=external_reference.get_hashes(), element=ext_ref_element)
 
     @staticmethod
@@ -519,7 +519,7 @@ def _add_tool(self, parent_element: ElementTree.Element, tool: Tool, tag_name: s
         if tool.get_hashes():
             Xml._add_hashes_to_element(hashes=tool.get_hashes(), element=tool_element)
         if self.bom_metadata_supports_tools_external_references() and tool.get_external_references():
-            Xml._add_external_references_to_element(
+            self._add_external_references_to_element(
                 ext_refs=tool.get_external_references(), element=tool_element
             )