Skip to content

Commit 4c8a3ab

Browse files
committed
move tests to model bom file
Signed-off-by: gruebel <[email protected]>
1 parent 735c05e commit 4c8a3ab

File tree

2 files changed

+24
-20
lines changed

2 files changed

+24
-20
lines changed

tests/test_component.py

+1-19
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@
2424
from packageurl import PackageURL # type: ignore
2525

2626
from cyclonedx.model import sha1sum
27-
from cyclonedx.model.bom import Bom
2827
from cyclonedx.model.component import Component
29-
from data import get_component_setuptools_simple, get_component_setuptools_simple_no_version
28+
from data import get_component_setuptools_simple
3029

3130
FIXTURES_DIRECTORY = 'fixtures/xml/1.4'
3231

@@ -78,20 +77,3 @@ def test_from_file_with_path_for_bom(self) -> None:
7877
)
7978
self.assertEqual(c.purl, purl)
8079
self.assertEqual(len(c.hashes), 1)
81-
82-
def test_has_component_1(self) -> None:
83-
bom = Bom()
84-
bom.components.update([get_component_setuptools_simple(), get_component_setuptools_simple_no_version()])
85-
self.assertEqual(len(bom.components), 2)
86-
self.assertTrue(bom.has_component(component=get_component_setuptools_simple_no_version()))
87-
self.assertIsNot(get_component_setuptools_simple(), get_component_setuptools_simple_no_version())
88-
89-
def test_get_component_by_purl(self) -> None:
90-
bom = Bom()
91-
setuptools_simple = get_component_setuptools_simple()
92-
bom.components.add(get_component_setuptools_simple())
93-
94-
result = bom.get_component_by_purl(get_component_setuptools_simple().purl)
95-
96-
self.assertEqual(result, setuptools_simple)
97-
self.assertIsNone(bom.get_component_by_purl(get_component_setuptools_simple_no_version().purl))

tests/test_model_bom.py

+23-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,12 @@
2222
from cyclonedx.model import License, LicenseChoice, OrganizationalContact, OrganizationalEntity, Property
2323
from cyclonedx.model.bom import Bom, BomMetaData, ThisTool, Tool
2424
from cyclonedx.model.component import Component, ComponentType
25-
from data import get_bom_for_issue_275_components, get_bom_with_component_setuptools_with_vulnerability
25+
from data import (
26+
get_bom_for_issue_275_components,
27+
get_bom_with_component_setuptools_with_vulnerability,
28+
get_component_setuptools_simple,
29+
get_component_setuptools_simple_no_version,
30+
)
2631

2732

2833
class TestBomMetaData(TestCase):
@@ -127,3 +132,20 @@ def test_bom_nested_components_issue_275(self) -> None:
127132
# self.assertIsInstance(bom.metadata.component, Component)
128133
# self.assertEqual(2, len(bom.services))
129134
# bom.validate()
135+
136+
def test_has_component_1(self) -> None:
137+
bom = Bom()
138+
bom.components.update([get_component_setuptools_simple(), get_component_setuptools_simple_no_version()])
139+
self.assertEqual(len(bom.components), 2)
140+
self.assertTrue(bom.has_component(component=get_component_setuptools_simple_no_version()))
141+
self.assertIsNot(get_component_setuptools_simple(), get_component_setuptools_simple_no_version())
142+
143+
def test_get_component_by_purl(self) -> None:
144+
bom = Bom()
145+
setuptools_simple = get_component_setuptools_simple()
146+
bom.components.add(setuptools_simple)
147+
148+
result = bom.get_component_by_purl(get_component_setuptools_simple().purl)
149+
150+
self.assertIs(result, setuptools_simple)
151+
self.assertIsNone(bom.get_component_by_purl(get_component_setuptools_simple_no_version().purl))

0 commit comments

Comments
 (0)