Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3DDevice_LoadVertexShader_0 (LTCG) wrong order parameters #191

Open
RadWolfie opened this issue Feb 27, 2023 · 0 comments
Open

D3DDevice_LoadVertexShader_0 (LTCG) wrong order parameters #191

RadWolfie opened this issue Feb 27, 2023 · 0 comments
Labels
D3D8LTCG OOVPA relative topic priority-medium Medium priority

Comments

@RadWolfie
Copy link
Member

Even though parameters' names are matching with registers but the order is incorrect for the actual parameter.

D3DDevice_LoadVertexShader(dword_xt Handle, dword_xt Address);

The following function above demonstrate Handle is first parameter and Address is second parameter.
However, both CxbxR and this repositories are currently set to:

D3DDevice_LoadVertexShader_0__LTCG_eax_Address_ecx_Handle
D3DDevice_LoadVertexShader_0__LTCG_eax_Address_edx_Handle

when it should had been:

D3DDevice_LoadVertexShader_0__LTCG_ecx_Handle_eax_Address
D3DDevice_LoadVertexShader_0__LTCG_edx_Handle_eax_Address

Since we are currently moving away from named parameter onto register. It will be change to:

D3DDevice_LoadVertexShader_0__LTCG_ecx1_eax2
D3DDevice_LoadVertexShader_0__LTCG_edx1_eax2
@RadWolfie RadWolfie added priority-medium Medium priority D3D8LTCG OOVPA relative topic labels Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D3D8LTCG OOVPA relative topic priority-medium Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant