Skip to content

Commit ffccfdc

Browse files
authored
Merge pull request #6 from lkck24/PSR12
PSR12 fixes
2 parents 33f7273 + 9953b9e commit ffccfdc

5 files changed

+31
-7
lines changed

composer.json

+4-2
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,11 @@
2121
"squizlabs/php_codesniffer": "^3.5.5"
2222
},
2323
"scripts": {
24-
"check": ["@analyze", "@test"],
24+
"check": ["@analyze", "@test", "@cs-check"],
2525
"test": "pest tests",
26-
"analyze": "phpstan analyse --level max"
26+
"analyze": "phpstan analyse --level max",
27+
"cs-check": "phpcs --parallel=50",
28+
"cs-fix": "phpcbf"
2729
},
2830
"autoload": {
2931
"psr-4": {

phpcs.xml.dist

+21
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
<?xml version="1.0"?>
2+
<ruleset name="PSR12 coding standard">
3+
<!-- display progress -->
4+
<arg value="p"/>
5+
<arg name="colors"/>
6+
7+
<!-- inherit rules from: -->
8+
<rule ref="PSR12">
9+
<exclude name="Generic.Files.LineLength"/>
10+
</rule>
11+
<rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
12+
<rule ref="Squiz.WhiteSpace.SuperfluousWhitespace">
13+
<properties>
14+
<property name="ignoreBlankLines" value="false"/>
15+
</properties>
16+
</rule>
17+
18+
<!-- Paths to check -->
19+
<file>src</file>
20+
<file>tests</file>
21+
</ruleset>

tests/Fixture/CircularReferenceObjectB.php

-2
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,4 @@ public function setObjectA(CircularReferenceObjectA $objectA): void
1818
{
1919
$this->objectA = $objectA;
2020
}
21-
22-
2321
}

tests/Fixture/SelfReferencingObjects.php

-1
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,4 @@ public function getNumber(): int
2727
{
2828
return $this->number;
2929
}
30-
3130
}

tests/ObjectGraphGeneratorTest.php

+6-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ public function itShouldUseTemporaryConfigBeforeRegistry(): void
3535
$objectGraphGenerator = $this->getUnitUnderTest();
3636
/** @var SimpleTypesInConstructor $actual */
3737
$actual = $objectGraphGenerator->generateWithTemporaryConfig(SimpleTypesInConstructor::class, [
38-
'Cubicl\ObjectGraphGenerator\Tests\Fixture\SimpleTypesInConstructor:bar' => function () {return true;},
38+
'Cubicl\ObjectGraphGenerator\Tests\Fixture\SimpleTypesInConstructor:bar' => function () {
39+
return true;
40+
},
3941
]);
4042

4143
$this->assertTrue($actual->isBar());
@@ -58,7 +60,9 @@ private function getUnitUnderTest(): ObjectGraphGenerator
5860
{
5961
return new ObjectGraphGenerator([
6062
SelfReferencingObjects::class => new SelfReferencingObjectsFactory(),
61-
'Cubicl\ObjectGraphGenerator\Tests\Fixture\SimpleTypesInConstructor:bar' => function () {return false;},
63+
'Cubicl\ObjectGraphGenerator\Tests\Fixture\SimpleTypesInConstructor:bar' => function () {
64+
return false;
65+
},
6266
]);
6367
}
6468
}

0 commit comments

Comments
 (0)