[HasMany] Ensure it returns a collection even if parent does not exist #15

Author: TZK-

src/Bridges/Laravel/Relations/HasMany.php

@@ -6,6 +6,7 @@
 use Cristal\ApiWrapper\Relations\HasMany as CoreHasMany;
 use Illuminate\Database\Eloquent\Model as ModelEloquent;
 use LogicException;
+use Illuminate\Support\Collection;
 
 class HasMany extends CoreHasMany
 {
@@ -26,12 +27,13 @@ public function __construct($parent, Model $related, $foreignKey, $localKey)
         $this->addConstraints();
     }
 
-    /**
-     * @param $data
-     * @return mixed
-     */
     public function getRelationsFromArray($data)
     {
-        return collect(parent::getRelationsFromArray($data));
+        return new Collection(parent::getRelationsFromArray($data));
+    }
+
+    public function getResults()
+    {
+        return new Collection(parent::getResults());
     }
 }

src/Relations/HasMany.php

@@ -49,4 +49,15 @@ public function getRelationsFromArray($data)
             return new $class($item, isset($item[$this->localKey]));
         }, $data);
     }
+
+    public function getResults()
+    {
+        $results = parent::getResults();
+
+        if (null === $results) {
+            return [];
+        }
+
+        return $results;
+    }
 }