Skip to content

Add tests for graceful shutdown mid-request #1187

Description

@Baskarayelu

Summary��grace

ul shutdown mid-request.��## Background��We want to keep the credential-issuance API auditable and sa
e to change. Landing this issue tightens one speci
ic corner and gives reviewers a clear di

to reason about rather than a general "cleanup" commit. It should be scoped small enough to close in a single PR.��## Acceptance criteria��- [ ] The change matches the summary above.�- [ ] Tests cover the new behavior (happy path + one e
plicit
ailure mode).�- [ ] Lint, type-check, and tests all pass locally.�- [ ] PR description re
erences this issue with Closes #<this-issue>.��## Implementation hints��- Pick the right test layer: unit tests inside the a

ected module
or pure logic, integration tests under tests/
or cross-module behaviour.�- Cover the happy path and at least one e
plicit sad path.�- Where the project uses proptest/ ast-check/ c, pre
er a property test over many hand-written cases. Commit any
ailing seed back to the repo.�- Keep test names assertive (returns_zero_when_balance_is_zero), not interrogative.��## Repo-speci
ic notes��- Node.js/TypeScript service. Install with npm ci and run npm test / npm run lint be
ore pushing.�- Follow the e
isting NestJS module layout — controllers thin, services own business logic.�- Prisma is the ORM; add new tables via prisma migrate dev --name <slug> and commit the generated migration.�- Do not log credential payloads in plainte
t — use the e
isting RedactedLogger.��## Out o
scope��- Unrelated re
actors in adjacent
iles.�- Stylistic-only changes (
ormatting, renaming) that are not required by the
i
.�- Anything beyond the acceptance criteria above; sur
ace
ollow-ups as separate issues.��## How to claim and submit��
. Comment on this issue saying you'd like to take it on; wait
or a maintainer to assign you (avoids duplicated e

ort).�2. Open a PR that re
erences this issue (Closes #<this-issue>).�3. Make sure CI is green and request review
rom a CODEOWNERS maintainer.�4. PRs that close this issue and pass review may quali
y
or a reward — see the MAYBE REWARDED label and the FWC26 campaign page.��---��Category: test  ·  Campaign: GrantFo
OSS · O

icial Campaign | FWC26 · Maybe Rewarded

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions