Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The onRest doesn't get called when the wheel is stopped by hand (click or tap) #44

Open
matronator opened this issue Jun 10, 2024 · 1 comment

Comments

@matronator
Copy link

I looked at the code and it looks like in the events.js the touch/mouse events don't discriminate between a stationary wheel and a spinning one. I think there should be some condition to check if the wheel is spinning and is stopped by the tap/click, to call onRest. I would do a PR, but I'm not sure if I have it correct.

@muhammadbasitobaid
Copy link

Yes, there should be something like onStop for stop() or onRest() should be called for stop as well!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants