Skip to content

chore: Remove HasIBC2EntryPoints #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kulikthebird opened this issue Apr 28, 2025 · 2 comments · Fixed by #2465
Closed

chore: Remove HasIBC2EntryPoints #2463

kulikthebird opened this issue Apr 28, 2025 · 2 comments · Fixed by #2465

Comments

@kulikthebird
Copy link
Member 

          Currently the HasIBC2EntryPoint flag is used only during instantiation and migration procedure to register the contract to the ibc-go router. If IBC team will implement [the prefix-based routing](https://github.com/cosmos/ibc-go/pull/8303) this flag won't be used anymore. We can consider calling `AnalyzeCode` each time an IBCv2 message comes before calling the entry point. Though we might end up with increasing the time spent on double-checking a contract, which is already part of calling the entrypoint in CosmWasm.

So we have to decide if we want to keep this flag in the contract analysis report at all

Originally posted by @kulikthebird in #2454 (comment)
@kulikthebird kulikthebird changed the title HasIBC2EntryPoint is not used chore: Remove HasIBC2EntryPoin Apr 28, 2025
@kulikthebird kulikthebird changed the title chore: Remove HasIBC2EntryPoin chore: Remove HasIBC2EntryPoint Apr 28, 2025
@kulikthebird kulikthebird changed the title chore: Remove HasIBC2EntryPoint chore: Remove HasIBC2EntryPoints Apr 28, 2025
@chipshort
Copy link
Collaborator

As mentioned in #2454 (comment), I think we can remove it.

@ThanhNhann ThanhNhann mentioned this issue Apr 30, 2025
Merged
@ThanhNhann
Copy link
Contributor

hi @kulikthebird, I just made a pr for this issue, could you please check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove HasIBC2EntryPoints ThanhNhann/cosmwasm
3 participants
@chipshort @kulikthebird @ThanhNhann