Merge pull request #9 from Wail-LT/fix/type/is-http-error

amanteaux · web-flow · commit 182bb740d448 · 2025-01-29T09:26:38.000+01:00
Fix of isHttpError function type
diff --git a/src/lib/promise/HttpPromise.ts b/src/lib/promise/HttpPromise.ts
@@ -50,8 +50,8 @@ export function unwrapHttpPromise<T>(httpPromise: Promise<HttpResponse<T>>): Pro
  *
  * Returns `true` if the object seems to be a {@link HttpError}, else `false`.
  */
-export function isHttpError(object: unknown) {
-  return object && typeof object === 'object' && (object as HttpError).errorCode !== undefined;
+export function isHttpError(object: unknown): object is HttpError {
+  return Boolean(object && typeof object === 'object' && (object as HttpError).errorCode !== undefined);
 }
 
 function safeThen<P, R>(thenFunction: PromiseFunction<P, R>, debugContext?: object): PromiseFunction<P, R> {

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,8 @@ export function unwrapHttpPromise<T>(httpPromise: Promise<HttpResponse<T>>): Pro`
`50`	`50`	`*`
`51`	`51`	* Returns `true` if the object seems to be a {@link HttpError}, else `false`.
`52`	`52`	`*/`
`53`		`-export function isHttpError(object: unknown) {`
`54`		`- return object && typeof object === 'object' && (object as HttpError).errorCode !== undefined;`
	`53`	`+export function isHttpError(object: unknown): object is HttpError {`
	`54`	`+ return Boolean(object && typeof object === 'object' && (object as HttpError).errorCode !== undefined);`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`function safeThen<P, R>(thenFunction: PromiseFunction<P, R>, debugContext?: object): PromiseFunction<P, R> {`