Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lolhtml for arm? #3

Open
macosupdate opened this issue Jun 14, 2021 · 2 comments
Open

lolhtml for arm? #3

macosupdate opened this issue Jun 14, 2021 · 2 comments

Comments

@macosupdate
Copy link

I tested on macos and it works fine, I plan to try it on arm specifically armv7
In the build folder I don't see any library for arm, can you create a library for arm, or guide so I can build?
I hope it works on arm

@macosupdate
Copy link
Author

macosupdate commented Jun 14, 2021

I got an error while building
cargo build --lib --release --target armv7-unknown-linux-gnueabihf --manifest-path c-api/Cargo.toml
But have been successful when using
cross build --target armv7-unknown-linux-gnueabihf --lib --release --manifest-path c-api/Cargo.toml

now i have to create linux-arm or arm-linux-gnueabihf folder to copy the liblolhtml.a file into it

@CoolSpring8
Copy link
Owner

Hi, is everything working out for you now?

I got an error while building
cargo build --lib --release --target armv7-unknown-linux-gnueabihf --manifest-path c-api/Cargo.toml

It is probably related to rust-lang/rust#28924. (Currently cross-compilation of Rust requires you to manually specify the linker for the target architecture. Maybe cross did that for you silently.)

In the build folder I don't see any library for arm, can you create a library for arm, or guide so I can build?

Glad to hear that you have successfully built the binary. So is there still a need for me to add something to the build folder?

I am hesitant in this matter for the following reasons:

  • Using a git repository itself to distribute binary doesn't seem like a good idea. Each time the binaries are updated, the repository will grow unnecessarily larger.

  • I'm not sure what architectures should be included because there are too many of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants