Skip to content

Conversation

@conservationtimothy
Copy link
Contributor

Goal

Closes #19.

Screenshots

Screenshot 2025-11-09 at 20 18 38 Screenshot 2025-11-10 at 12 15 33

What I changed

  • Redesigned GC Landing page header with new tab-style design featuring curved SVG edges
  • Implemented responsive behavior:
    • Desktop layout shows above 1000px with progressive tab button positioning
    • Mobile layout with hamburger menu shows below 1000px
    • Text sizes scale down to text-xs at 1200px and below for Guardian Connector, welcome message, and sign out button
  • Added mobile hamburger menu with:
    • User icon with checkmark (represents logged-in user)
    • User Management link (admin only)
    • Language Picker with text label
    • Sign Out button
  • Centered service cards for better display when communities have 1-2 services

What I'm not doing here

  • No changes to authentication logic
  • No changes to service functionality
  • No changes to mobile menu behavior beyond UI

LLM use disclosure

Used LLM for consultation and code generation throughout the responsive redesign implementation, including:

  • Responsive breakpoint strategy and Tailwind class selection
  • Mobile menu structure and styling

Copy link
Contributor

@IamJeffG IamJeffG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rudokemper I think you will do a better review of the Vue code than I am able. Can I punt to you?

"userManagement": "User Management",
"secureAccessRequired": "Secure Access Required",
"pleaseSignInToAccess": "Please sign in to access your community tools"
"pleaseSignInToAccess": "Please sign in to access your partner tools"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems awkward to me. Did someone ask for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I remember a conversation with Rudo about how not everyone we support is a community, some are "partners"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "partner" is quite right either. If someone self-deploys GC, they are not our partner.

Maybe just "access your tools"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file needed? if so, can you at least rename it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted


// if (loggedIn.value && to.path === "/login") {
// return router.push("/");
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended to be commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've restored

@rudokemper
Copy link
Member

@IamJeffG @conservationtimothy Yes, I will review this.

Copy link
Member

@rudokemper rudokemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely looks good but a handful requested changes throughout.

<p class="text-gray-400">
<p class="text-gray-600">
{{ t('services.noServicesDescription') }}
</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below this (glancing at the code, not sure if it's exactly here or a higher level of <div> containment), can we add a helpful paragraph (localized text), maybe italicized:

Need help? Visit the Guardian Connector documentation website. (link to docs.guardianconnector.net)

@@ -0,0 +1,126 @@
<script lang="ts" setup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the same icon on UserManagement

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, Auth0Login has a warning complaining about the absence of LanguagePicker component. Could implement this there too to resolve that warning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I now see there is also a LanguagePicker. Can we just use one?

I'm not sure and haven't looked into it, but I suspect this warning for the Auth0Login page could also be related:

 WARN  [Vue warn]: Component <Anonymous> is missing template or render function. 
  at <Anonymous theme="white" > 
  at <Auth0Login error-message="" > 
  at <Login onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< undefined > > 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is kinda nicer I think since we've redesigned maybe we use this one thru out

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you didn't do this, which is fine. Shall we create an issue to do this work?

Actually, maybe that issue can just request implementing the same folder+tab header design for the User Management page. In order to have a consistent design across all pages of the this application.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and then separately, an issue to track the warnings / errors in Auth0Login

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#38

Copy link
Member

@rudokemper rudokemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please just go ahead and make the one requested change about actually adding the "Need help" blurb to the index before merging, and create an issue to track user management header redesign work.

@@ -0,0 +1,126 @@
<script lang="ts" setup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you didn't do this, which is fine. Shall we create an issue to do this work?

Actually, maybe that issue can just request implementing the same folder+tab header design for the User Management page. In order to have a consistent design across all pages of the this application.

Comment on lines +29 to +30
"needHelp": "Need help? Visit the Guardian Connector",
"documentationWebsite": "documentation website",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this implemented on index.vue. Can we add?

This is what I had in mind btw;

image

@conservationtimothy conservationtimothy merged commit 834033a into main Nov 13, 2025
1 check passed
@conservationtimothy conservationtimothy deleted the feat/landing-page-redesign branch November 13, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI Improvements for GC Landing Page

4 participants