Hotfix/Unable to unset criteria page object. (#5)

Author: othercodes

src/Infrastructure/Laravel/Persistence/EloquentCriteriaParser.php

@@ -171,8 +171,11 @@ private function applyOrdering(Builder $builder, Order $ordering): Builder
      */
     private function applyPage(Builder $builder, Page $page): Builder
     {
-        $builder = $builder->limit($page->limit());
+        if ($page->limit() > 0) {
+            $builder = $builder->limit($page->limit());
+            $builder = $builder->offset($page->offset());
+        }
 
-        return $builder->offset($page->offset());
+        return $builder;
     }
 }

tests/Integration/EloquentCriteriaParserTest.php

@@ -242,3 +242,14 @@
     expect($builder->toRawSql())
         ->toBe('select * from "users" where "first_name" = \'Vincent\' or ("last_name" = \'Winnfield\') limit 25 offset 0');
 });
+
+test('EloquentCriteriaParser should ignore Page object if limit is 0.', function () {
+    $parser = new EloquentCriteriaParser();
+
+    $criteria = Criteria::default()
+        ->withPageLimit(0);
+    $builder = $parser->applyCriteria(UserDatabaseSource::query(), $criteria);
+
+    expect($builder->toRawSql())
+        ->toBe('select * from "users"');
+});