Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Package Identities #661

Open
20 tasks
michael-hawker opened this issue Mar 20, 2025 · 0 comments
Open
20 tasks

Inconsistent Package Identities #661

michael-hawker opened this issue Mar 20, 2025 · 0 comments
Assignees
Labels
bug 🐛 Something isn't working nuget 📦

Comments

@michael-hawker
Copy link
Member

Describe the bug

The following are missing .Controls. in their Package Ids:

  • OpacityMaskView
  • Ribbon
  • TitleBar

i.e. they're missing this

<PackageId>$(PackageIdPrefix).$(PackageIdVariant).Controls.$(ToolkitComponentName)</PackageId>

This breaks the links to the packages in ADO from the Sample App with CommunityToolkit/Tooling-Windows-Submodule#275

There are other larger inconsistencies here we should investigate fixing for 8.3.

Ideally, all projects and namespaces are simple and aligned to the practices we have in the main repo (no Labs). Only thing that has Labs is the PackageId for when pushed to NuGet feeds.

Steps to reproduce

-

Expected behavior

Sample App can link to these packages consistently based on project name pattern it has access to.

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

@michael-hawker michael-hawker added the bug 🐛 Something isn't working label Mar 20, 2025
@michael-hawker michael-hawker moved this to 🆕 New in Toolkit 8.x Mar 20, 2025
@Arlodotexe Arlodotexe self-assigned this Apr 1, 2025
@Arlodotexe Arlodotexe moved this from 🆕 New to 🔖 Ready in Toolkit 8.x Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working nuget 📦
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants