Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapr redis ext fixes #517

Closed

Conversation

FullStackChef
Copy link
Contributor

@FullStackChef FullStackChef commented Mar 1, 2025

Closes #515 & #435

  • Corrected version format from "v1.0" to "v1"
  • Added missing principalId parameter
  • Refactored to move "WithParameter" calls outside of ConfigureInfrastructure and use redisBuilder.Resource.UseAccessKeyAuthentication
  • Removed IsPackable false flag

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@FullStackChef FullStackChef force-pushed the dapr-redis-ext-fixes branch from 9f311d3 to a0629e5 Compare March 5, 2025 04:23
@FullStackChef
Copy link
Contributor Author

@aaronpowell What do I need to do to get this merged in

@aaronpowell
Copy link
Member

I'll create a 9.3 release (since it's a new integration) and roll it into that, will aim before the end of the week.

@aaronpowell aaronpowell added this to the 9.3 milestone Mar 5, 2025
@FullStackChef FullStackChef force-pushed the dapr-redis-ext-fixes branch from a0629e5 to 54e3acc Compare March 7, 2025 06:22
@FullStackChef FullStackChef mentioned this pull request Mar 7, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dapr Azure Redis extensions not working as expected
2 participants