Retraining models required for fixing #593

[schen149]

TL;DR: We will need to retrain PrepSRL, Quantifier, (maybe) Question Typer

The Fix applied to #593 (currently residing in branch string_join_require_retrain) will affect the behavior of FeatureNGramUtility in edison. All 4 feature generating functions in FeatureNGramUtility calls StringUtils.join() to produce feature names, which currently have trailing dashes. The fix removes the trailing dash, but also changes the feature names.

Here are all packages that will (likely) be affected --

• PrepSRL
  

  cogcomp-nlp/prepsrl/src/main/java/edu/illinois/cs/cogcomp/prepsrl/features/WordBigrams.java

  Lines 38 to 39 in 7d9dad3

  	features.addAll(FeatureNGramUtility.getNgramsOrdered(list, 1, surfaceFormTransformer));
  	features.addAll(FeatureNGramUtility.getNgramsOrdered(list, 2, surfaceFormTransformer));

• Quantifier
  

  cogcomp-nlp/quantifier/src/main/java/edu/illinois/cs/cogcomp/quant/features/WordBigrams.java

  Lines 44 to 45 in 7d9dad3

  	features.addAll(FeatureNGramUtility.getNgramsOrdered(list, 1, surfaceFormTransformer));
  	features.addAll(FeatureNGramUtility.getNgramsOrdered(list, 2, surfaceFormTransformer));

• Question Typer
  (it looks like just a debug/helper function, not actually used in model? but not sure)
  

  cogcomp-nlp/question-type/src/main/java/edu/illinois/cs/cogcomp/question_typer/QuestionTyperFeatureExtractorsUtils.java

  Lines 191 to 200 in 7d9dad3

  	public static void getNgrams(TextAnnotation s) {
  	List cons = s.getView(ViewNames.LEMMA).getConstituents();
  	for(int i = 2; i <= 4; i++) {
  	List ngramOrdred = FeatureUtilities.getFeatureSet(FeatureNGramUtility.getLabelNgramsOrdered(cons, i));
  	String label = i + "gramTokensOrdered";
  	for(int ii = 0; ii < ngramOrdred.size(); ii++) {
  	System.out.println((String) ngramOrdred.get(ii));
  	}
  	}
  	}