Skip to content
This repository was archived by the owner on Apr 21, 2024. It is now read-only.

Commit 8408706

Browse files
authored
Merge pull request #14 from Coder-Spirit/fix-unnecessary-readonly
fix: remove problematic readonly modifier
2 parents 90d6627 + c1e9a33 commit 8408706

File tree

5 files changed

+96
-96
lines changed

5 files changed

+96
-96
lines changed

Diff for: .github/workflows/tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
uses: actions/setup-node@v2
2727
with:
2828
node-version: ${{ matrix.node-version }}
29-
- run: npm install -g yarn
29+
- run: if [ "$(node --version)" \< "v17" ]; then npm install -g yarn; fi
3030
- run: yarn install
3131
- run: yarn test
3232
- run: yarn lint

Diff for: lambda-ioc/deno/container.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ type ContextualParamsToSyncResolverKeys<
2020
TSyncDependencies extends Record<ConstrainedKey, unknown>,
2121
TAsyncDependencies extends Record<ConstrainedKey, unknown>,
2222
TParams extends
23-
| readonly (
23+
| (
2424
| TSyncDependencies[keyof TSyncDependencies]
2525
| ReadableSyncContainer<Partial<TSyncDependencies>>
2626
| ReadableAsyncContainer<Partial<TAsyncDependencies>>
@@ -42,7 +42,7 @@ type ContextualParamsToAsyncResolverKeys<
4242
TSyncDependencies extends Record<ConstrainedKey, unknown>,
4343
TAsyncDependencies extends Record<ConstrainedKey, unknown>,
4444
TParams extends
45-
| readonly (
45+
| (
4646
| TSyncDependencies[keyof TSyncDependencies]
4747
| TAsyncDependencies[keyof TAsyncDependencies]
4848
| ReadableSyncContainer<Partial<TSyncDependencies>>
@@ -235,7 +235,7 @@ export interface WritableContainer<
235235

236236
registerConstructor<
237237
TName extends ConstrainedKey,
238-
TParams extends readonly (
238+
TParams extends (
239239
| TSyncDependencies[keyof TSyncDependencies]
240240
| ReadableSyncContainer<Partial<TSyncDependencies>>
241241
| ReadableAsyncContainer<Partial<TAsyncDependencies>>
@@ -286,7 +286,7 @@ export interface WritableContainer<
286286
*/
287287
registerAsyncConstructor<
288288
TName extends ConstrainedKey,
289-
TParams extends readonly (
289+
TParams extends (
290290
| TSyncDependencies[keyof TSyncDependencies]
291291
| TAsyncDependencies[keyof TAsyncDependencies]
292292
| ReadableSyncContainer<Partial<TSyncDependencies>>
@@ -531,7 +531,7 @@ function __createContainer<
531531

532532
registerConstructor<
533533
TName extends ConstrainedKey,
534-
TParams extends readonly (
534+
TParams extends (
535535
| TSyncDependencies[keyof TSyncDependencies]
536536
| ReadableSyncContainer<Partial<TSyncDependencies>>
537537
| ReadableAsyncContainer<Partial<TAsyncDependencies>>
@@ -584,7 +584,7 @@ function __createContainer<
584584

585585
registerAsyncConstructor<
586586
TName extends ConstrainedKey,
587-
TParams extends readonly (
587+
TParams extends (
588588
| TSyncDependencies[keyof TSyncDependencies]
589589
| TAsyncDependencies[keyof TAsyncDependencies]
590590
| ReadableSyncContainer<Partial<TSyncDependencies>>

Diff for: lambda-ioc/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@coderspirit/lambda-ioc",
3-
"version": "0.7.0",
3+
"version": "0.7.1",
44
"main": "./dist/cjs/index.js",
55
"module": "./dist/esm/index.js",
66
"types": "./dist/cjs/index.d.ts",
@@ -38,11 +38,11 @@
3838
"test": "jest"
3939
},
4040
"devDependencies": {
41-
"@types/jest": "^27.4.0",
41+
"@types/jest": "^27.4.1",
4242
"@types/node": "^14.14.37",
43-
"@typescript-eslint/eslint-plugin": "^5.12.0",
44-
"@typescript-eslint/parser": "^5.12.0",
45-
"eslint": "^8.9.0",
43+
"@typescript-eslint/eslint-plugin": "^5.12.1",
44+
"@typescript-eslint/parser": "^5.12.1",
45+
"eslint": "^8.10.0",
4646
"eslint-config-prettier": "^8.4.0",
4747
"eslint-plugin-jest": "^26.1.1",
4848
"eslint-plugin-node": "^11.1.0",

Diff for: lambda-ioc/src/container.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ type ContextualParamsToSyncResolverKeys<
2020
TSyncDependencies extends Record<ConstrainedKey, unknown>,
2121
TAsyncDependencies extends Record<ConstrainedKey, unknown>,
2222
TParams extends
23-
| readonly (
23+
| (
2424
| TSyncDependencies[keyof TSyncDependencies]
2525
| ReadableSyncContainer<Partial<TSyncDependencies>>
2626
| ReadableAsyncContainer<Partial<TAsyncDependencies>>
@@ -42,7 +42,7 @@ type ContextualParamsToAsyncResolverKeys<
4242
TSyncDependencies extends Record<ConstrainedKey, unknown>,
4343
TAsyncDependencies extends Record<ConstrainedKey, unknown>,
4444
TParams extends
45-
| readonly (
45+
| (
4646
| TSyncDependencies[keyof TSyncDependencies]
4747
| TAsyncDependencies[keyof TAsyncDependencies]
4848
| ReadableSyncContainer<Partial<TSyncDependencies>>
@@ -235,7 +235,7 @@ export interface WritableContainer<
235235

236236
registerConstructor<
237237
TName extends ConstrainedKey,
238-
TParams extends readonly (
238+
TParams extends (
239239
| TSyncDependencies[keyof TSyncDependencies]
240240
| ReadableSyncContainer<Partial<TSyncDependencies>>
241241
| ReadableAsyncContainer<Partial<TAsyncDependencies>>
@@ -286,7 +286,7 @@ export interface WritableContainer<
286286
*/
287287
registerAsyncConstructor<
288288
TName extends ConstrainedKey,
289-
TParams extends readonly (
289+
TParams extends (
290290
| TSyncDependencies[keyof TSyncDependencies]
291291
| TAsyncDependencies[keyof TAsyncDependencies]
292292
| ReadableSyncContainer<Partial<TSyncDependencies>>
@@ -531,7 +531,7 @@ function __createContainer<
531531

532532
registerConstructor<
533533
TName extends ConstrainedKey,
534-
TParams extends readonly (
534+
TParams extends (
535535
| TSyncDependencies[keyof TSyncDependencies]
536536
| ReadableSyncContainer<Partial<TSyncDependencies>>
537537
| ReadableAsyncContainer<Partial<TAsyncDependencies>>
@@ -584,7 +584,7 @@ function __createContainer<
584584

585585
registerAsyncConstructor<
586586
TName extends ConstrainedKey,
587-
TParams extends readonly (
587+
TParams extends (
588588
| TSyncDependencies[keyof TSyncDependencies]
589589
| TAsyncDependencies[keyof TAsyncDependencies]
590590
| ReadableSyncContainer<Partial<TSyncDependencies>>

0 commit comments

Comments
 (0)