Sharing iP code quality feedback [for @Codekrodile]

[soc-se-bot]

@Codekrodile We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, to help you improve the iP code further.

IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most three example are given i.e., there can be other areas/places to improve.

Aspect: Tab Usage

Example from src/main/java/Lubot.java lines 5-5:

[TAB]private static ArrayList<Task> tasks = new ArrayList<>();

Example from src/main/java/Lubot.java lines 6-6:

[TAB]private static int n = 0;

Example from src/main/java/Lubot.java lines 48-48:

[TAB][TAB][TAB][TAB]System.out.println(horizontalBar);

Suggestion: As specified by the coding standard, use spaces instead of tabs.

Aspect: Naming boolean variables/methods

No easy-to-detect issues 👍

Aspect: Brace Style

No easy-to-detect issues 👍

Aspect: Package Name Style

No easy-to-detect issues 👍

Aspect: Class Name Style

No easy-to-detect issues 👍

Aspect: Dead Code

No easy-to-detect issues 👍

Aspect: Method Length

No easy-to-detect issues 👍

Aspect: Class size

No easy-to-detect issues 👍

Aspect: Header Comments

No easy-to-detect issues 👍

Aspect: Recent Git Commit Messages

possible problems in commit a3bb922:

modified task and subclasses to be more immutable

• Not in imperative mood (?)

possible problems in commit 38a5fe1:

added delete function

• Not in imperative mood (?)

possible problems in commit a34977d:

fixed minor event error handling, updated auto testing

• Not in imperative mood (?)

Suggestion: Follow the given conventions for Git commit messages for future commits (do not modify past commit messages as doing so will change the commit timestamp that we used to detect your commit timings).

Aspect: Binary files in repo

No easy-to-detect issues 👍

---

ℹ️ The bot account used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact cs2103@comp.nus.edu.sg if you want to follow up on this post.