Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fb api graph version #1003

Closed
selul opened this issue Aug 20, 2024 · 13 comments · Fixed by #1004 or #1006
Closed

Upgrade fb api graph version #1003

selul opened this issue Aug 20, 2024 · 13 comments · Fixed by #1004 or #1006
Assignees
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project

Comments

@selul
Copy link
Contributor

selul commented Aug 20, 2024

What problem does this address?

We can look into using the latest API graph version since right now we are using an older one.

What is your proposed solution?

No response

Will this feature require documentation? (Optional)

None

@selul selul added the new feature Request for a new feature or functionality to be added to the project. label Aug 20, 2024
@selul
Copy link
Contributor Author

selul commented Aug 21, 2024

@vytisbulkevicius we need to address this in the next 2 weeks since the current version will no longer be supported after half of see https://github.com/Codeinwp/tweet-old-post-pro/issues/558

@vytisbulkevicius
Copy link
Contributor

@vytisbulkevicius vytisbulkevicius added enhancement Request to improve or optimize an existing feature or functionality in the project and removed new feature Request for a new feature or functionality to be added to the project. labels Aug 21, 2024
@girishpanchal30
Copy link
Contributor

I don't see it elsewhere, but can you check @girishpanchal30 as well?

@vytisbulkevicius I'll check and let you know here

@selul
Copy link
Contributor Author

selul commented Aug 21, 2024

we need to check also the app site, https://github.com/Codeinwp/rop-auth-service

@girishpanchal30
Copy link
Contributor

@selul could you please provide test Facebook app credentials so I can connect it to my local setup?

Here:
image

@girishpanchal30 girishpanchal30 linked a pull request Aug 22, 2024 that will close this issue
@girishpanchal30
Copy link
Contributor

@selul I've checked, and the ROP APP is supportsv16.0, so I think we don't need any major changes.
Ref: https://github.com/search?q=repo%3ACodeinwp%2Frop-auth-service%20default_graph_version&type=code

Please review this PR and share your thoughts.

Thanks

@selul
Copy link
Contributor Author

selul commented Aug 22, 2024

@girishpanchal30 is there any issue if we use the latest? I don't have any test app, feel free to create one.

@girishpanchal30
Copy link
Contributor

@selul I've tested v20.0 and I don't see any issue locally.

I see that ROP also has a staging environment, which we can test here.

https://github.com/Codeinwp/rop-auth-service?tab=readme-ov-file#revive-old-post-central-auth-service

I've opened a new PR for the ROP app, can you please merge it into development?

For testing, we need to change the app URL here - https://github.com/Codeinwp/tweet-old-post/blob/master/tweet-old-post.php#L177

@selul
Copy link
Contributor Author

selul commented Aug 22, 2024

I've merged it.

@girishpanchal30
Copy link
Contributor

I'll check and let you know, Thanks

@girishpanchal30
Copy link
Contributor

@selul While I tested with staging it seems authentication is working fine but after authentication ROP app returns an empty pages list on staging.
Ref: https://tinyurl.com/27kdcfo9

I've tested it before merging the PR, and the results are the same.

Ref: https://tinyurl.com/23t4ewuk

@Soare-Robert-Daniel @selul Do you have any idea about this error?

Thanks

@selul
Copy link
Contributor Author

selul commented Aug 22, 2024

seems like it was out of sync the branch, I've synced it.

@girishpanchal30
Copy link
Contributor

@selul Now it working fine and also post sharing is working.
Ref: https://tinyurl.com/22xbkal4

Thanks

@vytisbulkevicius vytisbulkevicius linked a pull request Aug 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants