Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge and Reset confusions #873

Open
AndreeaCristinaRadacina opened this issue Jan 31, 2024 · 4 comments · Fixed by #1007
Open

Purge and Reset confusions #873

AndreeaCristinaRadacina opened this issue Jan 31, 2024 · 4 comments · Fixed by #1007
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.

Comments

@AndreeaCristinaRadacina
Copy link

AndreeaCristinaRadacina commented Jan 31, 2024

A user mentioned that when he clicks on Purge & Reset, either clicking Cancel or Ok, the output is the same.

ref: https://secure.helpscout.net/conversation/2494044153/402147?viewId=212390

Here are my findings:

  • when you click on Purge&Reset and then OK => all posts are removed, and the status in the Imports dashboard contains "-" symbols - https://vertis.d.pr/i/s0ypc6
  • when you click on Purge&Reset and then Cancel => posts are not removed (it works as expected), but the status in the Imports dashboard is the same as in the "OK" case https://vertis.d.pr/i/qVElkd

The problem is that the status is not necessarily intuitive.

@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Jan 31, 2024
@vytisbulkevicius vytisbulkevicius added the bug This label could be used to identify issues that are caused by a defect in the product. label Nov 24, 2024
@girishpanchal30 girishpanchal30 linked a pull request Nov 26, 2024 that will close this issue
6 tasks
@girishpanchal30
Copy link
Contributor

I've added an improvement related to the Purge and Reset functionality in this PR. Please review the attached PR and let me know if you encounter any issues.

@vytisbulkevicius
Copy link
Contributor

@girishpanchal30,

I see that with this PR posts do not actually get deleted but they are removed from the Cumulative count as nothing was imported, screencast: https://vertis.d.pr/v/UITH53

Clicking Cancel should take no action at all, just close the popup.

@girishpanchal30
Copy link
Contributor

@vytisbulkevicius The posts will be deleted when the user clicks the Ok button. If the user clicks the Cancel button, it will simply reset the import job.

Let me know if you have any other suggestions for this issue.
Thanks!

@vytisbulkevicius
Copy link
Contributor

Ok, got it. I thought about having a cancel button to close the the popup as if it was clicked accidentally and don't purge the import. But it makes sense to have it like this as the text in the popup clarifies the action. We can keep it like this, thanks for the confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants