From 24de376da899bca661cfce841e1bc8aa2df66825 Mon Sep 17 00:00:00 2001 From: Liam Greenfield <52577696+Liam310@users.noreply.github.com> Date: Thu, 11 Jun 2026 12:32:24 +0100 Subject: [PATCH 1/2] remove references to dead code review channel --- org-cyf/content/itp/data-flows/success/index.md | 2 +- org-cyf/content/itp/data-groups/success/index.md | 2 +- org-cyf/content/itp/onboarding/success/index.md | 2 +- org-cyf/content/itp/structuring-data/success/index.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/org-cyf/content/itp/data-flows/success/index.md b/org-cyf/content/itp/data-flows/success/index.md index d43bfbca7..7099dee48 100644 --- a/org-cyf/content/itp/data-flows/success/index.md +++ b/org-cyf/content/itp/data-flows/success/index.md @@ -44,6 +44,6 @@ weight = 11 1. Submit the issue link to step 4 of ITP on [CYF Course Portal](https://application-process.codeyourfuture.io/). > [!NOTE] -> A pull request is _completed_ when a volunteer has added the "Complete" tag. If nobody has reviewed your PR after one week, please ask on Slack in #cyf-code-review. +> A pull request is _completed_ when a volunteer has added the "Complete" tag. Celebrate your hard work by checking off the objectives below! diff --git a/org-cyf/content/itp/data-groups/success/index.md b/org-cyf/content/itp/data-groups/success/index.md index eae71d0f8..9df02accb 100644 --- a/org-cyf/content/itp/data-groups/success/index.md +++ b/org-cyf/content/itp/data-groups/success/index.md @@ -41,6 +41,6 @@ weight = 11 1. Submit the issue link to step 3 of ITP on [CYF Course Portal](https://application-process.codeyourfuture.io/). > [!NOTE] -> A pull request is _completed_ when a volunteer has added the "Complete" tag. If nobody has reviewed your PR after one week, please ask on Slack in #cyf-code-review. +> A pull request is _completed_ when a volunteer has added the "Complete" tag. Celebrate your hard work by checking off the objectives below! diff --git a/org-cyf/content/itp/onboarding/success/index.md b/org-cyf/content/itp/onboarding/success/index.md index e4d10c5d7..dc75b23f6 100644 --- a/org-cyf/content/itp/onboarding/success/index.md +++ b/org-cyf/content/itp/onboarding/success/index.md @@ -45,6 +45,6 @@ weight = 11 1. **[Apply to enroll as a Trainee](https://forms.gle/vRuofa7aeL5DsbhGA)**. > [!NOTE] -> A pull request is _completed_ when a volunteer has added the "Complete" tag. If nobody has reviewed your PR after one week, please ask on Slack in #cyf-code-review. +> A pull request is _completed_ when a volunteer has added the "Complete" tag. Celebrate your hard work by checking off the objectives below! diff --git a/org-cyf/content/itp/structuring-data/success/index.md b/org-cyf/content/itp/structuring-data/success/index.md index 47b1a1893..cbdc38402 100644 --- a/org-cyf/content/itp/structuring-data/success/index.md +++ b/org-cyf/content/itp/structuring-data/success/index.md @@ -47,6 +47,6 @@ weight = 11 1. Submit the issue link to step 2 of ITP on [CYF Course Portal](https://application-process.codeyourfuture.io/). > [!NOTE] -> A pull request is _completed_ when a volunteer has added the "Complete" tag. If nobody has reviewed your PR after one week, please ask on Slack in #cyf-code-review. +> A pull request is _completed_ when a volunteer has added the "Complete" tag. Celebrate your hard work by checking off the objectives below! From 1edf1896b853933b263b5fc2b43dc88315ede20e Mon Sep 17 00:00:00 2001 From: Liam Greenfield <52577696+Liam310@users.noreply.github.com> Date: Thu, 11 Jun 2026 12:39:24 +0100 Subject: [PATCH 2/2] update guide for locating first PR --- org-cyf-guides/content/reviewing/code-review-basics/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org-cyf-guides/content/reviewing/code-review-basics/index.md b/org-cyf-guides/content/reviewing/code-review-basics/index.md index 2880b8010..ebdb63124 100644 --- a/org-cyf-guides/content/reviewing/code-review-basics/index.md +++ b/org-cyf-guides/content/reviewing/code-review-basics/index.md @@ -109,6 +109,6 @@ If you want to dive deeper into code review, check out these resources: ## Practice Exercise -Find an open pull request in the [#cyf-code-review](https://codeyourfutur-yov6609.slack.com/archives/C07QX99JK7B) channel and practice reviewing it using this guide. +Find an open pull request by joining the [#cyf-code-review-volunteer-team](https://codeyourfutur-yov6609.slack.com/archives/C0A1E83EZRP) channel and following one of the links in the **Code Review Resources** tab. Once you've chosen one, practice reviewing it using this guide. Remember: Code review is a conversation, not a judgment. We're all learning!