Skip to content

Commit dc24947

Browse files
authored
Fix typos in legacy code practices (#1908)
1 parent 0bbe693 commit dc24947

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • common-content/en/module/legacy/practices-to-remember

common-content/en/module/legacy/practices-to-remember/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Some of our standard development practices are _even more important_ when workin
1616

1717
### Formatting
1818

19-
We should be _consistent_ with our formatting. We may not have any control over what decisions were made in the past. When we're writing brand new code in a new code, we can choose whether we use two spaces or four. But when we jump into an existing codebase, we should use whatever style it already has. If we send a PR fixing a small bug, and it changes every line in the file, it's really hard to see what changed, and what stayed the same. If we have two people joining a codebase, and one is reformatting every file they touch to use two spaces, and the other is reformatting every file they touch to use two spaces, there are going to be lots of spurious changes, and lots of merge conflicts.\
19+
We should be _consistent_ with our formatting. We may not have any control over what decisions were made in the past. When we're writing brand new code in a new code, we can choose whether we use two spaces or four. But when we jump into an existing codebase, we should use whatever style it already has. If we send a PR fixing a small bug, and it changes every line in the file, it's really hard to see what changed, and what stayed the same. If we have two people joining a codebase, and one is reformatting every file they touch to use two spaces, and the other is reformatting every file they touch to use four spaces, there are going to be lots of spurious changes, and lots of merge conflicts.
2020

2121
To approach this, we may need to:
2222
* Disable our auto code formatters

0 commit comments

Comments
 (0)