Skip to content

Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 5 |Prep exercises#510

Closed
enjoy15 wants to merge 10 commits into
CodeYourFuture:mainfrom
enjoy15:sprint5-prep-excercises
Closed

Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 5 |Prep exercises#510
enjoy15 wants to merge 10 commits into
CodeYourFuture:mainfrom
enjoy15:sprint5-prep-excercises

Conversation

@enjoy15

@enjoy15 enjoy15 commented Apr 22, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed all exercises

@enjoy15 enjoy15 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 5 Assigned during Week 5 of this module labels Apr 22, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 13, 2026
LonMcGregor
LonMcGregor reviewed May 13, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "double" prep exercise is missing
The methods task is missing an explanation, otherwise all good.

Comment thread sprint5-prep-exercises/methods.py
@@ -0,0 +1,28 @@
from datetime import date

@LonMcGregor LonMcGregor May 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanations of methods vs functions is missing

@enjoy15 enjoy15 May 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the note. I’ve added a brief explanation of the difference between functions and methods at the top of the file for clarity.

Comment thread sprint5-prep-exercises/enums.py

@LonMcGregor LonMcGregor May 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to separate out useful helper functions for parsing inputs

@enjoy15 enjoy15 May 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 13, 2026
@enjoy15

enjoy15 commented May 13, 2026

Copy link
Copy Markdown
Author

The "double" prep exercise is missing The methods task is missing an explanation, otherwise all good.

The "double" prep exercise added.

@enjoy15 enjoy15 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 13, 2026
LonMcGregor
LonMcGregor reviewed May 16, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This cw is complete now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 16, 2026
@illicitonion

illicitonion commented Jun 30, 2026

Copy link
Copy Markdown
Member

Closing PR because the SDC run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 5 Assigned during Week 5 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@enjoy15 @illicitonion @LonMcGregor