London | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 5 | Prep Exercises #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zohrehKazemianpour
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jan 14, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Very good work on these tasks, there are some areas where you could improve further
There was a problem hiding this comment.
Can you describe the difference and any dis/advantage of using a class method vs a function?
| self.preferred_operating_system = preferred_operating_system | ||
|
|
||
| def is_adult(self) -> bool: | ||
| today_date = date.today().year |
There was a problem hiding this comment.
Be careful about the formatting and indentation here
| def print_family_tree(person: Person) -> None: | ||
| print(person.name) | ||
| for child in person.children: | ||
| print(f"- {child.name} ({child.age})") |
There was a problem hiding this comment.
Can this print grandchildren recursively?
There was a problem hiding this comment.
To improve the user experience, you might want to do some validation on the input and ask for reentry if it is invalid. You might also want to give some options when asking for an OS
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR contains the Sprint 5 preparation exercise.
As I was not previously familiar with Python, it took me some time to get comfortable with the new concepts and syntax. I added as many comments as possible for educational purposes, as I plan to use this code later as a reference.
Questions
I would really appreciate any feedback on my implementation and suggestions on how I can improve my code quality.