London| SDC-Nov-2025 | Ikenna Agulobi | sprint 4 | Cowsay exercise #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ike-agu
added
the
Needs Review
LonMcGregor
added
the
Review in progress
|
Can you remove the venv directory please? I can't review so many files |
LonMcGregor
added
Reviewed
Author
|
@LonMcGregor I've deleted the venv directory. Thank you for mentioning it. |
ike-agu
added
the
Needs Review
LonMcGregor
reviewed
Jan 20, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Great, this is almost perfect. When you run the output, is it correct? Is there anything extra being printed that could be removed?
LonMcGregor
removed
the
Needs Review
LonMcGregor
reviewed
Jan 20, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
great work, this task is complete now
LonMcGregor
added
Complete
Author
|
@LonMcGregor Thank you for reviewing my PR and flagging the extra 'None' being printed. I’ve fixed the issue by removing the 'print()' call, as the 'cowsay' functions already print their output and return 'None'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR contains my implementation of the cowsay CLI tool with argparse, dynamic animal list, and message support