Skip to content

Glasgow | 26-ITP-May | Chan Yat Long | Sprint 1 | Form Control #1225

Open
Motorcycle-lab wants to merge 11 commits into
CodeYourFuture:mainfrom
Motorcycle-lab:main
Open

Glasgow | 26-ITP-May | Chan Yat Long | Sprint 1 | Form Control #1225
Motorcycle-lab wants to merge 11 commits into
CodeYourFuture:mainfrom
Motorcycle-lab:main

Conversation

@Motorcycle-lab
Copy link
Copy Markdown

@Motorcycle-lab Motorcycle-lab commented May 6, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I finished the requirement of the form control.
I have improved the grammar of the html that I have formed.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 6, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 1f7fc07
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69fdfe77636ee200080d9eac
😎 Deploy Preview https://deploy-preview-1225--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 68 (🔴 down 18 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

3 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Motorcycle-lab Motorcycle-lab changed the title Glasglow | 26-ITP-May | Chan Yat Long | Sprint 1 | Form Control Glasgow | 26-ITP-May | Chan Yat Long | Sprint 1 | Form Control May 6, 2026
@Motorcycle-lab Motorcycle-lab added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module Module-Onboarding The name of the module. labels May 6, 2026
@Poonam-raj Poonam-raj added 🐂 Size Medium 1-4 hours Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. Core This is a core task and should be completed by all trainees and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 11, 2026
@github-actions
Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

4 similar comments
@github-actions
Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions
Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions
Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions
Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Poonam-raj Poonam-raj removed 🐂 Size Medium 1-4 hours Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. Core This is a core task and should be completed by all trainees labels May 11, 2026
@github-actions
Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

2 similar comments
@github-actions
Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions
Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Poonam-raj
Copy link
Copy Markdown
Contributor

Hi Chan, please look at this pull request again - I don't want to review it until you've taken out the unrelated code (wireframe) please remove all work relating to wireframe so the only file changed is the form control html page.

@Poonam-raj Poonam-raj added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 11, 2026
@github-actions
Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants