Skip to content

Commit 709c10a

Browse files
committed
Fix HTML issues from PR review
1 parent 314bce2 commit 709c10a

1 file changed

Lines changed: 57 additions & 30 deletions

File tree

Form-Controls/index.html

Lines changed: 57 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -12,51 +12,78 @@
1212
<h1>Product Pick</h1>
1313
</header>
1414
<main>
15-
<form><libel for="name">Customer name:</libel><br>
16-
<input
17-
type="text"
18-
id="name"
19-
title="Name must contain only letters and spaces"><br><br>
15+
<form>
16+
17+
<!--Customer Name-->
18+
<label for="name">Full Name:</label>
19+
<input type="text" placeholder="Enter your name" id="name" minlength="2" pattern="[A-Za-z ]+"
20+
title="Name should contain only letters and spaces" required><br><br>
2021

21-
<label for="email">Email Address</label>
22-
<br>
22+
<!--Customer Email-->
23+
<label for="email">Email Address:</label>
2324
<input
2425
type="email"
26+
placeholder="Enter your email"
2527
id="email"
2628
name="email"
2729
required>
2830
<br><br>
29-
<label for="colour">T-Shirt Colour:</label>
30-
<br>
31-
<select id="colour" name="colour"required>
32-
<option value="select a colour">Select a colour</option>
33-
<option value="Pink">Pink</option>
34-
<option value="Aqua">Aqua</option>
35-
<option value="White">White</option>
36-
</select>
37-
<br><br>
31+
<!--Product Pick-->
32+
<fieldset>
33+
<legend>Choose T-shirt Colour</legend>
34+
<label>
35+
<input
36+
type="radio"
37+
name="colour"
38+
value="white"
39+
required>
40+
White
41+
</label>
42+
43+
<label>
44+
<input
45+
type="radio"
46+
name="colour"
47+
value="aqua"
48+
required>
49+
Aqua
50+
</label>
51+
52+
<label>
53+
<input
54+
type="radio"
55+
name="colour"
56+
value="pink"
57+
required>
58+
Pink
59+
</label>
60+
</fieldset>
61+
62+
63+
<br>
3864
<fieldset>
39-
<legend>T-Shirt Size</legend>
65+
<legend>Choose T-Shirt Size</legend>
4066
<input type="radio" id="xs" name="size" value="xs">
41-
<label for="xs">xs</label>
42-
<input type="radio" id="s" name="size" value="s">
43-
<label for="s">s</label>
44-
<input type="radio" id="m" name="size" value="m">
45-
<label for="m">m</label>
46-
<input type="radio" id="l" name="size" value="l">
47-
<label for="l">l</label>
48-
<input type="radio" id="xl" name="size" value="xl">
49-
<label for="xl">xl</label>
50-
<input type="radio" id="xxl" name="size" value="xxl">
51-
<label for="xxl">xxl</label>
67+
<label for="xs">XS</label>
68+
<input type="radio" id="s" name="size" value="S">
69+
<label for="s">S</label>
70+
<input type="radio" id="m" name="size" value="M">
71+
<label for="m">M</label>
72+
<input type="radio" id="l" name="size" value="L">
73+
<label for="l">L</label>
74+
<input type="radio" id="xl" name="size" value="XL">
75+
<label for="xl">XL</label>
76+
<input type="radio" id="xxl" name="size" value="XXL">
77+
<label for="xxl">XXL</label>
5278

53-
</fieldset>
79+
</fieldset><br><br>
80+
<button type="submit">Submit</button>
5481

5582
</form>
5683
</main>
5784
<footer>
5885
<!-- Fattouma Ouannassi-->
59-
<h2>Fattouma Ouannassi</h2>
86+
<h2>By Fattouma Ouannassi</h2>
6087
</footer>
6188
</body>
6289
</html>

0 commit comments

Comments
 (0)