improve laptop allocation efficiency

Author: sheetalkharab

allocate_laptop.py

@@ -1,6 +1,6 @@
 from dataclasses import dataclass
 from enum import Enum
-from typing import Dict, List
+from typing import Dict, List, Optional
 
 class OperatingSystem(Enum):
     MACOS = "macOS"
@@ -28,24 +28,32 @@ class Laptop:
     operating_system: OperatingSystem
 
 
-def allocate_laptops(people: List[Person], laptops: List[Laptop]) -> Dict[Person, Laptop]: 
-    allocations: Dict[Person, Laptop] = {}
+def allocate_laptops(people: List[Person], laptops: List[Laptop]) -> Dict[Person, Optional[Laptop]]: 
+    allocations: Dict[Person,  Optional[Laptop]] = {}
     available_laptops = laptops.copy()
 
     for person in people:
-        # Find laptop that gives this person minimum sadness
-        if available_laptops:
-            best_laptop = min(available_laptops, key=lambda l: calculate_sadness(person, l))
-            allocations[person] = best_laptop
-            available_laptops.remove(best_laptop)  # Laptop now allocated
+        allocated = None
+        for preferred_os in person.preferred_operating_system:
+            for laptop in available_laptops:
+                if laptop.operating_system == preferred_os:
+                    allocated = laptop
+                    break
+            if allocated:
+                break
+        
+        if allocated:
+            
+            allocations[person] = allocated
+            available_laptops.remove(allocated) 
         else:
             # No laptops left, assign None or a “dummy” Laptop with sadness 100
             allocations[person] = None 
 
     return allocations  
 
 
-def calculate_sadness(person: Person, laptop: Laptop) -> int:
+def calculate_sadness(person: Person, laptop: Optional[Laptop]) -> int:
     """Return sadness for a person if given this laptop."""
     if laptop is None:
         return 100  # no laptop, maximum sadness
@@ -84,5 +92,4 @@ def calculate_sadness(person: Person, laptop: Laptop) -> int:
         print(f"{person.name} got {laptop.manufacturer} {laptop.model} ({laptop.operating_system.value}) "
             f"→ Sadness: {calculate_sadness(person, laptop)}")
     else:
-        print(f"{person.name} got no laptop → Sadness: 100")
-
+        print(f"{person.name} got no laptop → Sadness: 100")