From 600fa9d18ee25ebdc7e3471059ff57f4f65769f6 Mon Sep 17 00:00:00 2001 From: Imran Mohamed Date: Sat, 25 Oct 2025 15:48:21 +0100 Subject: [PATCH 1/8] implemented median function --- Sprint-1/fix/median.js | 32 +++++++++++++++++++++++++++++--- Sprint-1/package.json | 2 +- 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/Sprint-1/fix/median.js b/Sprint-1/fix/median.js index b22590bc6..9fe2920a9 100644 --- a/Sprint-1/fix/median.js +++ b/Sprint-1/fix/median.js @@ -6,9 +6,35 @@ // or 'list' has mixed values (the function is expected to sort only numbers). function calculateMedian(list) { - const middleIndex = Math.floor(list.length / 2); - const median = list.splice(middleIndex, 1)[0]; - return median; + //check if its an array and has elements + if(!Array.isArray(list) || list.length === 0) { + return null; + } + + //filter only numbers + const filteredList = list.filter(item => typeof item === 'number' && !isNaN(item)); + + //if no numbers present return null + if(filteredList.length === 0) { + return null; + } + + //sort the filtered list + filteredList.sort((a, b) => a - b); + + const isEven = filteredList.length % 2 === 0; + + if(isEven ){ + const mid1 = filteredList.length / 2 - 1; + const mid2 = mid1 + 1; + const median = (filteredList[mid1] + filteredList[mid2]) / 2; + return median + }else { + const mid = Math.floor(filteredList.length / 2); + const median = filteredList[mid]; + return median; + }; + } module.exports = calculateMedian; diff --git a/Sprint-1/package.json b/Sprint-1/package.json index 330755010..d209f25f9 100644 --- a/Sprint-1/package.json +++ b/Sprint-1/package.json @@ -2,7 +2,7 @@ "name": "week-1", "version": "1.0.0", "description": "This README will guide you through the different sections for this week.", - "main": "writers.js", + "main": "median.js", "scripts": { "test": "jest" }, From 03c0785f0f0e086334f888387232b6fb34f15927 Mon Sep 17 00:00:00 2001 From: Imran Mohamed Date: Sun, 26 Oct 2025 13:26:24 +0000 Subject: [PATCH 2/8] implemented dedupe function and associated tests --- Sprint-1/implement/dedupe.js | 13 ++++++++++++- Sprint-1/implement/dedupe.test.js | 17 ++++++++++++++--- 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/Sprint-1/implement/dedupe.js b/Sprint-1/implement/dedupe.js index 781e8718a..7f7aaa4cb 100644 --- a/Sprint-1/implement/dedupe.js +++ b/Sprint-1/implement/dedupe.js @@ -1 +1,12 @@ -function dedupe() {} +function dedupe(arr) { + if(!arr.length) return []; + const result = []; + arr.forEach(item => { + if(!result.includes(item)) { + result.push(item); + } + }); + return result; +} + +module.exports = dedupe; \ No newline at end of file diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index 23e0f8638..c8dd552b7 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -1,4 +1,5 @@ -const dedupe = require("./dedupe.js"); +const dedupe = require('./dedupe'); + /* Dedupe Array @@ -16,12 +17,22 @@ E.g. dedupe([1, 2, 1]) target output: [1, 2] // Given an empty array // When passed to the dedupe function // Then it should return an empty array -test.todo("given an empty array, it returns an empty array"); +test("given an empty array, it returns an empty array", () => { + expect(dedupe([])).toEqual([]); +}); // Given an array with no duplicates // When passed to the dedupe function // Then it should return a copy of the original array +test("given an array with no duplicates, it returns a copy of the original array", () => { + expect(dedupe([1,2,3])).toEqual([1,2,3]); +}); // Given an array with strings or numbers // When passed to the dedupe function -// Then it should remove the duplicate values, preserving the first occurence of each element +// Then it should remove the duplicate values, preserving the first occurrence of each element +test("given an array with strings or numbers, it removes duplicate values preserving the first occurrence of each element", () => { + expect(dedupe(['a','a','a','b','b','c'])).toEqual(['a','b','c']); + expect(dedupe([1,1,2,2,3,1,2,4,5,5])).toEqual([1,2,3,4,5]); + expect(dedupe([1,2,1])).toEqual([1,2]); +}); \ No newline at end of file From c3da981ae2d244292c8f6983fbee8757999b7724 Mon Sep 17 00:00:00 2001 From: Imran Mohamed Date: Sun, 26 Oct 2025 13:38:07 +0000 Subject: [PATCH 3/8] implemented find max function and associated tests --- Sprint-1/implement/max.js | 9 ++++++++- Sprint-1/implement/max.test.js | 25 ++++++++++++++++++++++--- 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/Sprint-1/implement/max.js b/Sprint-1/implement/max.js index 6dd76378e..78e66a0d1 100644 --- a/Sprint-1/implement/max.js +++ b/Sprint-1/implement/max.js @@ -1,4 +1,11 @@ -function findMax(elements) { +function findMax(arr) { + let max = -Infinity; + for (let i = 0; i < arr.length; i++) { + if (typeof arr[i] === 'number' && arr[i] > max) { + max = arr[i]; + } + } + return max; } module.exports = findMax; diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 82f18fd88..27424b3d3 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -16,28 +16,47 @@ const findMax = require("./max.js"); // When passed to the max function // Then it should return -Infinity // Delete this test.todo and replace it with a test. -test.todo("given an empty array, returns -Infinity"); +test("given an empty array, returns -Infinity", () => { + expect(findMax([])).toBe(-Infinity); +}); // Given an array with one number // When passed to the max function // Then it should return that number - +test("given an array with one number, returns that number", () => { + expect(findMax([42])).toBe(42); +}); // Given an array with both positive and negative numbers // When passed to the max function // Then it should return the largest number overall +test("given an array with both positive and negative numbers, returns the largest number", () => { + expect(findMax([-1,0,5,20,-30])).toBe(20); +}); // Given an array with just negative numbers // When passed to the max function // Then it should return the closest one to zero +test("given an array with just negative numbers, returns the closest one to zero", () => { + expect(findMax([-10,-5,-1,-20])).toBe(-1); +}); // Given an array with decimal numbers // When passed to the max function // Then it should return the largest decimal number +test("given an array with decimal numbers, returns the largest decimal number", () => { + expect(findMax([1.5,22.5,0.75,20.13])).toBe(22.5); +}); // Given an array with non-number values // When passed to the max function // Then it should return the max and ignore non-numeric values - +test("given an array with non-number values, returns the max and ignores non-numeric values", () => { + expect(findMax([10,"hello",20,"100"])).toBe(20); +}); // Given an array with only non-number values // When passed to the max function // Then it should return the least surprising value given how it behaves for all other inputs +test("given an array with only non-number values, returns -Infinity", () => { + expect(findMax(["a","b","c","d"])).toBe(-Infinity); +}); + From 2d73b6104e26c486e7520497e1a5b047b70bc69b Mon Sep 17 00:00:00 2001 From: Imran Mohamed Date: Sun, 26 Oct 2025 13:54:27 +0000 Subject: [PATCH 4/8] implemented sum function and associated tests --- Sprint-1/implement/sum.js | 8 +++++++- Sprint-1/implement/sum.test.js | 19 ++++++++++++++++++- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/Sprint-1/implement/sum.js b/Sprint-1/implement/sum.js index 9062aafe3..70cf7a96c 100644 --- a/Sprint-1/implement/sum.js +++ b/Sprint-1/implement/sum.js @@ -1,4 +1,10 @@ -function sum(elements) { +function sum(arr) { + return arr.reduce((acc, curr) => { + if (typeof curr === 'number') { + return acc + curr; + } + return acc; + }, 0); } module.exports = sum; diff --git a/Sprint-1/implement/sum.test.js b/Sprint-1/implement/sum.test.js index dd0a090ca..c796ee98a 100644 --- a/Sprint-1/implement/sum.test.js +++ b/Sprint-1/implement/sum.test.js @@ -13,24 +13,41 @@ const sum = require("./sum.js"); // Given an empty array // When passed to the sum function // Then it should return 0 -test.todo("given an empty array, returns 0") +test("given an empty array, returns 0",()=>{ + expect(sum([])).toBe(0); +}) // Given an array with just one number // When passed to the sum function // Then it should return that number +test("given an array with one number, returns that number",()=>{ + expect(sum([20])).toBe(20); +}) // Given an array containing negative numbers // When passed to the sum function // Then it should still return the correct total sum +test("given an array with negative numbers, returns correct sum",()=>{ + expect(sum([-5,-10,-15])).toBe(-30); +}) // Given an array with decimal/float numbers // When passed to the sum function // Then it should return the correct total sum +test("given an array with decimal numbers, returns correct sum",()=>{ + expect(sum([1.5,2.5,3.5])).toBe(7.5); +}) // Given an array containing non-number values // When passed to the sum function // Then it should ignore the non-numerical values and return the sum of the numerical elements +test("given an array with non-number values, ignores them and returns correct sum",()=>{ + expect(sum([10,'hello',20,['test'],30,{a:'a'}])).toBe(60); +}) // Given an array with only non-number values // When passed to the sum function // Then it should return the least surprising value given how it behaves for all other inputs +test("given an array with only non-number values, returns 0",()=>{ + expect(sum(['hello','world',['test'],{a:'a'}])).toBe(0); +}) From 332dc0cc8bd14fac942fc3ec3a3300593a59610f Mon Sep 17 00:00:00 2001 From: Imran Mohamed Date: Sun, 26 Oct 2025 14:01:40 +0000 Subject: [PATCH 5/8] refactored includes function --- Sprint-1/refactor/includes.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Sprint-1/refactor/includes.js b/Sprint-1/refactor/includes.js index 29dad81f0..994131c59 100644 --- a/Sprint-1/refactor/includes.js +++ b/Sprint-1/refactor/includes.js @@ -1,8 +1,7 @@ // Refactor the implementation of includes to use a for...of loop function includes(list, target) { - for (let index = 0; index < list.length; index++) { - const element = list[index]; + for (let element of list) { if (element === target) { return true; } From 94f9d3e34136e2bacd8d5b4da78a07c673f7bfdf Mon Sep 17 00:00:00 2001 From: Imran Mohamed Date: Mon, 10 Nov 2025 18:55:22 +0000 Subject: [PATCH 6/8] refactor median function and tests for improved readability and consistency --- Sprint-1/fix/median.js | 19 ++++++++++--------- Sprint-1/fix/median.test.js | 22 +++++++++++++++++----- 2 files changed, 27 insertions(+), 14 deletions(-) diff --git a/Sprint-1/fix/median.js b/Sprint-1/fix/median.js index 9fe2920a9..a617e1388 100644 --- a/Sprint-1/fix/median.js +++ b/Sprint-1/fix/median.js @@ -7,34 +7,35 @@ function calculateMedian(list) { //check if its an array and has elements - if(!Array.isArray(list) || list.length === 0) { + if (!Array.isArray(list) || list.length === 0) { return null; } //filter only numbers - const filteredList = list.filter(item => typeof item === 'number' && !isNaN(item)); + const filteredList = list.filter( + (item) => typeof item === "number" && !isNaN(item) + ); //if no numbers present return null - if(filteredList.length === 0) { + if (filteredList.length === 0) { return null; } - + //sort the filtered list filteredList.sort((a, b) => a - b); const isEven = filteredList.length % 2 === 0; - if(isEven ){ + if (isEven) { const mid1 = filteredList.length / 2 - 1; const mid2 = mid1 + 1; const median = (filteredList[mid1] + filteredList[mid2]) / 2; - return median - }else { + return median; + } else { const mid = Math.floor(filteredList.length / 2); const median = filteredList[mid]; return median; - }; - + } } module.exports = calculateMedian; diff --git a/Sprint-1/fix/median.test.js b/Sprint-1/fix/median.test.js index 21da654d7..c262c3776 100644 --- a/Sprint-1/fix/median.test.js +++ b/Sprint-1/fix/median.test.js @@ -13,7 +13,8 @@ describe("calculateMedian", () => { { input: [1, 2, 3, 4], expected: 2.5 }, { input: [1, 2, 3, 4, 5, 6], expected: 3.5 }, ].forEach(({ input, expected }) => - it(`returns the median for [${input}]`, () => expect(calculateMedian(input)).toEqual(expected)) + it(`returns the median for [${input}]`, () => + expect(calculateMedian(input)).toEqual(expected)) ); [ @@ -24,7 +25,8 @@ describe("calculateMedian", () => { { input: [110, 20, 0], expected: 20 }, { input: [6, -2, 2, 12, 14], expected: 6 }, ].forEach(({ input, expected }) => - it(`returns the correct median for unsorted array [${input}]`, () => expect(calculateMedian(input)).toEqual(expected)) + it(`returns the correct median for unsorted array [${input}]`, () => + expect(calculateMedian(input)).toEqual(expected)) ); it("doesn't modify the input array [3, 1, 2]", () => { @@ -33,8 +35,17 @@ describe("calculateMedian", () => { expect(list).toEqual([3, 1, 2]); }); - [ 'not an array', 123, null, undefined, {}, [], ["apple", null, undefined] ].forEach(val => - it(`returns null for non-numeric array (${val})`, () => expect(calculateMedian(val)).toBe(null)) + [ + "not an array", + 123, + null, + undefined, + {}, + [], + ["apple", null, undefined], + ].forEach((val) => + it(`returns null for non-numeric array (${val})`, () => + expect(calculateMedian(val)).toBe(null)) ); [ @@ -45,6 +56,7 @@ describe("calculateMedian", () => { { input: [3, "apple", 1, null, 2, undefined, 4], expected: 2.5 }, { input: ["banana", 5, 3, "apple", 1, 4, 2], expected: 3 }, ].forEach(({ input, expected }) => - it(`filters out non-numeric values and calculates the median for [${input}]`, () => expect(calculateMedian(input)).toEqual(expected)) + it(`filters out non-numeric values and calculates the median for [${input}]`, () => + expect(calculateMedian(input)).toEqual(expected)) ); }); From c83fbdc25c81b0a2eb2056e76381054817a9e43b Mon Sep 17 00:00:00 2001 From: Imran Mohamed Date: Mon, 10 Nov 2025 19:02:10 +0000 Subject: [PATCH 7/8] refactor dedupe tests --- Sprint-1/implement/dedupe.test.js | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index c8dd552b7..0f0ce4c5a 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -1,4 +1,4 @@ -const dedupe = require('./dedupe'); +const dedupe = require("./dedupe"); /* Dedupe Array @@ -25,14 +25,17 @@ test("given an empty array, it returns an empty array", () => { // When passed to the dedupe function // Then it should return a copy of the original array test("given an array with no duplicates, it returns a copy of the original array", () => { - expect(dedupe([1,2,3])).toEqual([1,2,3]); + const arr = ["a", "b", "c"]; + const result = dedupe(arr); + expect(result).toEqual(arr); + expect(result).not.toBe(arr); }); // Given an array with strings or numbers // When passed to the dedupe function // Then it should remove the duplicate values, preserving the first occurrence of each element test("given an array with strings or numbers, it removes duplicate values preserving the first occurrence of each element", () => { - expect(dedupe(['a','a','a','b','b','c'])).toEqual(['a','b','c']); - expect(dedupe([1,1,2,2,3,1,2,4,5,5])).toEqual([1,2,3,4,5]); - expect(dedupe([1,2,1])).toEqual([1,2]); -}); \ No newline at end of file + expect(dedupe(["a", "a", "a", "b", "b", "c"])).toEqual(["a", "b", "c"]); + expect(dedupe([1, 1, 2, 2, 3, 1, 2, 4, 5, 5])).toEqual([1, 2, 3, 4, 5]); + expect(dedupe([1, 2, 1])).toEqual([1, 2]); +}); From 46b4c0196725843abbe75c91d304adda75bda17a Mon Sep 17 00:00:00 2001 From: Imran Mohamed Date: Mon, 10 Nov 2025 19:06:18 +0000 Subject: [PATCH 8/8] refactor sum test for decimal numbers to use toBeCloseTo for precision --- Sprint-1/implement/sum.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sprint-1/implement/sum.test.js b/Sprint-1/implement/sum.test.js index c796ee98a..2fa132a9a 100644 --- a/Sprint-1/implement/sum.test.js +++ b/Sprint-1/implement/sum.test.js @@ -35,7 +35,7 @@ test("given an array with negative numbers, returns correct sum",()=>{ // When passed to the sum function // Then it should return the correct total sum test("given an array with decimal numbers, returns correct sum",()=>{ - expect(sum([1.5,2.5,3.5])).toBe(7.5); + expect(sum([1.5,2.5,3.5])).toBeCloseTo(7.5, 5); }) // Given an array containing non-number values