Fix multiput with proxy submodels #237
Merged
+47
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where in some scenarios, when using multiput on a models that have proxy submodel(a submodel without a db table) it would fail on trying to override superclass for that model instance(
_multi_put_override_superclassmethod in theviews.pyfile).Example stacktrace of the error:
Given the purpose of that method I think it is not needed to override the superclass with proxy subclass- it is essentialy the same model from the db perspective. Thats why when this happens I added
continuestatement in the subclass loop, so it tries to search for a valid subclass for overriding.Infact the newly added test is not really needed. Adding
Petproxy model, that inherits fromAnimalmodel is enough for existing inheritance tests to break.Additionaly after adding support for Django 4, the docker setup required bumping the version of Postgres container to 12 in order to work.