Get all users route #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nourshoreibah
requested changes
Oct 25, 2025
Collaborator
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
Awesome work! Just a couple quick suggestions to make sure tests pass. also sorry for all the merge commits
Co-authored-by: Nour Shoreibah <[email protected]>
Co-authored-by: Nour Shoreibah <[email protected]>
Co-authored-by: Nour Shoreibah <[email protected]>
Co-authored-by: Nour Shoreibah <[email protected]>
Co-authored-by: Nour Shoreibah <[email protected]>
denniwang
requested changes
Oct 30, 2025
| const normalizedPath = rawPath.replace(/\/$/, ''); | ||
| const method = (event.requestContext?.http?.method || event.httpMethod || 'GET').toUpperCase(); | ||
|
|
||
| console.log('DEBUG - rawPath:', rawPath, 'normalizedPath:', normalizedPath, 'method:', method); |
Contributor
There was a problem hiding this comment.
maybe remove if not needed anymore
| @@ -0,0 +1,5 @@ | |||
| module.exports = { | |||
Contributor
There was a problem hiding this comment.
wait why was i able to run jest tests without this
Contributor
There was a problem hiding this comment.
i got an error when i tried to test and it worked when i deleted it
Contributor
|
Business logic is all correct, I think my update test cases are screwing yours over. |
nourshoreibah
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #49
📝 Description
Added GET /users endpoint to retrieve users from the database. Optional pagination with page number and limit implemented.
Briefly list the changes made to the code:
✔️ Verification
Wrote Jest tests as well as checked different cases on Swagger to ensure it was working.
🏕️ (Optional) Future Work / Notes
Perhaps having user authentication for who can get users?