Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring/Blocking a user does not prevent them from joining a game #649

Open
GrantBartlett opened this issue Feb 1, 2025 · 0 comments · May be fixed by #651
Open

Ignoring/Blocking a user does not prevent them from joining a game #649

GrantBartlett opened this issue Feb 1, 2025 · 0 comments · May be fixed by #651

Comments

@GrantBartlett
Copy link
Member

Problem:

  • You can ignore users, but it does not prevent them from joining your hosted game.

Solution:

  • Check a user is in the host's ignore list, if they are, don't allow the user to join.

Things to check:

  1. Check all users in the lobby have ident info assigned when a user first joins the main channel.
    E.g. neogrant joins #cncnet-yr - does he have all ident info of every user in the channel, or just nicknames. (If we don't have ident info, we need an extra irc call (DoWhoQuery) or similar at the start to fetch all info on irc users so the client knows it all (So IRCUser isn't null)

  2. Add a check before a user joins the game lobby that the ident is not in the ignored list and prevent them from joining if they are. See GameChannel_UserAdded in CnCNetLobby.cs

@GrantBartlett GrantBartlett changed the title Ignoring/Blocking a user does not prevent them from a hosted game Ignoring/Blocking a user does not prevent them from joining a game Feb 1, 2025
@GrantBartlett GrantBartlett linked a pull request Feb 1, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant