Skip to content

Commit 3d09f58

Browse files
committed
Resolve merge conflicts in CI/CD workflow - Clean up test job structure and remove duplicate steps
1 parent 3097ed4 commit 3d09f58

File tree

1 file changed

+3
-16
lines changed

1 file changed

+3
-16
lines changed

.github/workflows/ci-cd.yml

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ jobs:
7070
build-and-push:
7171
name: Build & Push Docker Images
7272
runs-on: ubuntu-latest
73-
# REMOVED: No dependencies - runs in parallel
7473
outputs:
7574
image-digest: ${{ steps.build.outputs.digest }}
7675
steps:
@@ -114,7 +113,6 @@ jobs:
114113
test:
115114
name: Run Tests
116115
runs-on: ubuntu-latest
117-
# REMOVED: No dependencies - runs in parallel with build
118116
strategy:
119117
matrix:
120118
test-type: [frontend, backend]
@@ -153,17 +151,6 @@ jobs:
153151
if: matrix.test-type == 'frontend'
154152
run: |
155153
docker compose run nodejs bash -c "gulp dev && karma start --single-run && gulp staging"
156-
sudo curl -L "https://github.com/docker/compose/releases/download/v2.23.0/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
157-
sudo chmod +x /usr/local/bin/docker-compose
158-
docker-compose --version
159-
160-
- name: Set up Python 3.9
161-
uses: actions/setup-python@v4
162-
with:
163-
python-version: 3.9.21
164-
165-
- name: Install dependencies
166-
run: pip install awscli==1.18.66
167154
168155
- name: Run backend tests
169156
if: matrix.test-type == 'backend'
@@ -182,15 +169,15 @@ jobs:
182169
env:
183170
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
184171
run: |
185-
echo "Submitting coverage to Coveralls..."
172+
echo "Attempting to submit coverage to Coveralls..."
186173
docker-compose run -e DJANGO_SETTINGS_MODULE=settings.test -e COVERALLS_REPO_TOKEN=${{ secrets.COVERALLS_REPO_TOKEN }} django bash -c "
187174
pip install coveralls &&
188175
coveralls --rcfile=.coveragerc" || echo "Coveralls submission failed, but continuing workflow"
189-
176+
190177
deploy:
191178
name: Package & Deploy Services
192179
runs-on: ubuntu-latest
193-
needs: [build-and-push, test, quality-check] # Waits for ALL jobs to complete
180+
needs: [build-and-push, test, quality-check]
194181
if: github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main')
195182
environment: production
196183
steps:

0 commit comments

Comments
 (0)