Skip to content

AdaptiveTableLayout unnecesary sets allowBackup attribute #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vyguera opened this issue Dec 30, 2019 · 1 comment
Closed

AdaptiveTableLayout unnecesary sets allowBackup attribute #40

vyguera opened this issue Dec 30, 2019 · 1 comment

Comments

@vyguera
Copy link

vyguera commented Dec 30, 2019

Setting allowBackup attribute on my own application element at AndroidManifest makes an error with AdaptiveTableLayout, as its library Manifest already sets its own value for this attribute. Therefore is required to also set tools:replace="android:allowBackup in order to replace this value.

Error:Attribute application@allowBackup value=(false) from AndroidManifest.xml:10:9-36 is also present at [com.cleveroad:adaptivetablelayout:1.2.1] AndroidManifest.xml:12:9-35 value=(true).
Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:8:5-24:19 to override.

See http://g.co/androidstudio/manifest-merger for more information about the manifest merger.
vyguera pushed a commit to vyguera/AdaptiveTableLayout that referenced this issue Dec 30, 2019
Clean up to avoid having to add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml when developers sets their own allowBackup value on their actual application
@vyguera
Copy link
Author

vyguera commented Dec 30, 2019

I have fixed it in pull request #41

@vyguera vyguera closed this as completed Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant