Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorHandling.py Errors are Never Thrown #6

Open
Exper1mental opened this issue Feb 6, 2022 · 2 comments
Open

ErrorHandling.py Errors are Never Thrown #6

Exper1mental opened this issue Feb 6, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Exper1mental
Copy link
Member

It appears the errors listed in ``ErrorHandling.py` are never thrown for their respective issues. At least, I've not been able to invoke them when using roles that do not exist or stuff like that.

@Exper1mental Exper1mental added the bug Something isn't working label Feb 6, 2022
@TRJoseph
Copy link
Contributor

TRJoseph commented Feb 8, 2022

Currently have implemented a fix for this. I decided to handle more of the common errors inside of the function call with a try: except: approach. I feel as if this will help to give the user more accurate feedback for their specific misstep when using the bot. I kept more broad errors inside of the error handling .py in case something else goes awry such as trying to call a command that does not exist. Let me know what you think about this approach and I will close the issue if this sounds good.

@Exper1mental
Copy link
Member Author

Hmm... I'm inclined to say yes, but I'd need a better idea of what you're thinking of for this. They definitely should only include the specific line(s) relevant to the error though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants