Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Emojis That Do Not Exist Doesn't Throw an Error #3

Open
Exper1mental opened this issue Feb 6, 2022 · 2 comments
Open

Using Emojis That Do Not Exist Doesn't Throw an Error #3

Exper1mental opened this issue Feb 6, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Exper1mental
Copy link
Member

Adding role emojis that do not exist does not throw an error. Obviously, they don't show up in the reaction messages but an error isn't thrown either to let the user know they need to do something differently.

image

@Exper1mental Exper1mental added the bug Something isn't working label Feb 6, 2022
@TRJoseph
Copy link
Contributor

TRJoseph commented Feb 7, 2022

I believe these emojis in the format :emoji: are converted to unicode. I am not sure how to handle this as I believe it is out of d.py scope. I think I could download a table of unicode values and have it check if it exists in there but then that would need to be manually updated, right?

@Exper1mental
Copy link
Member Author

Exper1mental commented Feb 16, 2022

You could take a look at the emote cog from ClemBot. I think it literally just checks if the emote exists by fetching the image, and the error handling service handles any errors d.py throws.

Note that this method will probably only work with custom Discord emotes. Default ones would probably need that Unicode table your suggesting. If there is an API with a Unicode table, you could query that. Honestly just having your own array, javascript list, or something like that is probably all we need. It would definitely need to be documented so folks know to update the table as

I'm OK not having the Unicode table added at least initially. We only use custom emotes for our role reactions right now anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants