revision 4.1.0 — code review findings

[Copilot]

Reviewed the revision 4.1.0 PR (improved UI, bug fixes, Android power optimization bypass). No code changes were made; this documents findings from the review.

Critical Bug

• AlarmRingActivity.onPause / onUserLeaveHint lose intent extras — re-launch intent omits alarm_id, challenge_type, and difficulty, resetting challenge state to defaults mid-session:

  Intent intent = new Intent(this, AlarmRingActivity.class);
  intent.putExtra("alarm_id", alarmId);
  intent.putExtra("challenge_type", challengeType);
  intent.putExtra("difficulty", difficulty);
  intent.addFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT | Intent.FLAG_ACTIVITY_NEW_TASK);

Deprecation Warnings

• new Handler() without Looper in onPause — use new Handler(Looper.getMainLooper())
• Vibrator.vibrate(long[], int) — needs VibrationEffect branch for API 26+
• setSystemUiVisibility / SYSTEM_UI_FLAG_* — deprecated API 30+; WindowInsetsController preferred
• getAdapterPosition() in AlarmAdapter — replace with getBindingAdapterPosition()

Minor

• getStringExtra("challenge_type") can return null; assign a null-safe default after retrieval
• Replace e.printStackTrace() in AlarmStorage with android.util.Log.e(...)

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.