You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The SparseTimeFunction applies to either a 2D or 3D earth model. However, the data associated with a SparseTimeFunction is always 2D. This means that we have introduced a type instability for methods that use SparseTimeFunction. For example:
g =grid(rec)
will not be type stable, because we don't know (before-hand) if g should be 2D or if g should be 3D. One solution would be to add another type parameter to SparseTimeFunction that says if its associated with a 2D or 3D model.
I suppose the simplest solution would be to make N correspond to the model dimension. If, I undersand correctly, then the DevitoArray for a SparseTimeFunction is always N=2; so, that could be hard-coded.
The text was updated successfully, but these errors were encountered:
The
SparseTimeFunction
applies to either a 2D or 3D earth model. However, the data associated with aSparseTimeFunction
is always 2D. This means that we have introduced a type instability for methods that useSparseTimeFunction
. For example:will not be type stable, because we don't know (before-hand) if
g
should be 2D or ifg
should be 3D. One solution would be to add another type parameter toSparseTimeFunction
that says if its associated with a 2D or 3D model.I suppose the simplest solution would be to make N correspond to the model dimension. If, I undersand correctly, then the
DevitoArray
for aSparseTimeFunction
is alwaysN=2
; so, that could be hard-coded.The text was updated successfully, but these errors were encountered: