You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that this package does some type-piracy. Here are the two methods that I noticed.
The first method is the Distributed.addprocs(::AbstractString, ::Int; kwargs...) method. The AzManagers.jl package does not own the function (Distributed.addprocs) or either of the types (Base.AbstractString or Base.Int). (Keyword arguments do not participate in method dispatch.)
function Distributed.addprocs(template::AbstractString, n::Int; kwargs...)
The second method is the Distributed.addprocs(::Dict, ::Int; kwargs...) method. The AzManagers.jl package does not own the function (Distributed.addprocs) or any of the types (Base.Dict or Base.Int).
function Distributed.addprocs(template::Dict, n::Int;
This is not ideal.
There are a couple of ways to fix this. Probably the easiest would be to have a new function named AzManagers.addprocs_azure, and then the two above methods would become methods of the AzManagers.addprocs_azure function (instead of the Distributed.addprocs function).
The text was updated successfully, but these errors were encountered:
I noticed that this package does some type-piracy. Here are the two methods that I noticed.
The first method is the
Distributed.addprocs(::AbstractString, ::Int; kwargs...)
method. The AzManagers.jl package does not own the function (Distributed.addprocs
) or either of the types (Base.AbstractString
orBase.Int
). (Keyword arguments do not participate in method dispatch.)AzManagers.jl/src/AzManagers.jl
Line 866 in a07e78c
The second method is the
Distributed.addprocs(::Dict, ::Int; kwargs...)
method. The AzManagers.jl package does not own the function (Distributed.addprocs
) or any of the types (Base.Dict
orBase.Int
).AzManagers.jl/src/AzManagers.jl
Line 797 in a07e78c
This is not ideal.
There are a couple of ways to fix this. Probably the easiest would be to have a new function named
AzManagers.addprocs_azure
, and then the two above methods would become methods of theAzManagers.addprocs_azure
function (instead of theDistributed.addprocs
function).The text was updated successfully, but these errors were encountered: