Fix retry logic #149
Merged
Fix retry logic #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtkaplan
force-pushed
the
retrystart
branch
from
ef2dd75 to
54183a8
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
==========================================
- Coverage 47.11% 45.07% -2.04%
==========================================
Files 3 3
Lines 1696 1726 +30
==========================================
- Hits 799 778 -21
- Misses 897 948 +51 ☔ View full report in Codecov by Sentry. |
samtkaplan
force-pushed
the
retrystart
branch
from
54183a8 to
95300ca
Compare
Ensure retry logic on failed worker startup is triggered.
samtkaplan
force-pushed
the
retrystart
branch
from
95300ca to
d63f347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure retry logic on failed worker startup is triggered. In recent weeks, we observed that machines are failing to join the cluster. Further investigation showed that one cause was the initial worker/coordinator hand-shake. In this handshake the workers were seeing 0's instead of the cluster cookie. I do not understand why this is happening, but here we ensure that we have a functioning work-a-round. In particular, when we receive 0's at the worker during this handshake, we abandon and retry the process of joining the cluster.