18171 FIX suseconnect: don't crash when no subscription status is available

When using the suseconnect plugin, a situation could arise where subscription status is not available.
This werk implements a more graceful approach and avoids crashes when no subscription status is abailable.

Signed-off-by: Sven Rueß <[email protected]>

Closes: #824

Change-Id: I0a0bc8e6f6de4b0fc95a0ee45d74c900c94e7d0b

Author: sven-ruess

.werks/18171.md

@@ -0,0 +1,15 @@
+[//]: # (werk v2)
+# suseconnect: don't crash when no subscription status is available
+
+key        | value
+---------- | ---
+date       | 2025-07-15T15:25:26+00:00
+version    | 2.4.0p9
+class      | fix
+edition    | cre
+component  | checks
+level      | 1
+compatible | yes
+
+When using the suseconnect plugin, a situation could arise where subscription status is not available.
+This werk implements a more graceful approach and avoids crashes when no subscription status is available.

cmk/base/legacy_checks/suseconnect.py

@@ -69,49 +69,57 @@ def check_suseconnect(
     if (specs := get_data(section)) is None:
         return
 
-    state, infotext = 0, "Status: %(registration_status)s" % specs
-    if params["status"] != "Ignore" and params["status"] != specs["registration_status"]:
-        state = 2
-    yield state, infotext
+    if "registration_status" in specs:
+        state, infotext = 0, "Status: %s" % specs["registration_status"]
+        if params["status"] != "Ignore" and params["status"] != specs["registration_status"]:
+            state = 2
+        yield state, infotext
+
+    if "subscription_status" in specs:
+        state, infotext = 0, "Subscription: %s" % specs["subscription_status"]
+        if (
+            params["subscription_status"] != "Ignore"
+            and params["subscription_status"] != specs["subscription_status"]
+        ):
+            state = 2
+        yield state, infotext
 
-    state, infotext = 0, "Subscription: %(subscription_status)s" % specs
     if (
-        params["subscription_status"] != "Ignore"
-        and params["subscription_status"] != specs["subscription_status"]
+        "subscription_type" in specs
+        and "registration_code" in specs
+        and "starts_at" in specs
+        and "expires_at" in specs
     ):
-        state = 2
-    yield state, infotext
-
-    yield (
-        0,
-        (
-            "Subscription type: %(subscription_type)s, Registration code: %(registration_code)s, "
-            "Starts at: %(starts_at)s, Expires at: %(expires_at)s"
+        yield (
+            0,
+            (
+                "Subscription type: %(subscription_type)s, Registration code: %(registration_code)s, "
+                "Starts at: %(starts_at)s, Expires at: %(expires_at)s"
+            )
+            % specs,
         )
-        % specs,
-    )
 
-    expiration_date = time.strptime(specs["expires_at"], "%Y-%m-%d %H:%M:%S %Z")
-    expiration_time = time.mktime(expiration_date) - time.time()
+        expiration_date = time.strptime(specs["expires_at"], "%Y-%m-%d %H:%M:%S %Z")
+        expiration_time = time.mktime(expiration_date) - time.time()
 
-    if expiration_time > 0:
-        warn, crit = params["days_left"]
-        days2seconds = 24 * 60 * 60
+        if expiration_time > 0:
+            warn, crit = params["days_left"]
+            days2seconds = 24 * 60 * 60
 
-        if expiration_time <= crit * days2seconds:
-            state = 2
-        elif expiration_time <= warn * days2seconds:
-            state = 1
-        else:
-            state = 0
+            if expiration_time <= crit * days2seconds:
+                state = 2
+            elif expiration_time <= warn * days2seconds:
+                state = 1
+            else:
+                state = 0
 
-        infotext = "Expires in: %s" % render.timespan(expiration_time)
-        if state:
-            infotext += " (warn/crit at %d/%d days)" % (warn, crit)
+            infotext = "Expires in: %s" % render.timespan(expiration_time)
+            if state:
+                infotext += " (warn/crit at %d/%d days)" % (warn, crit)
 
-        yield state, infotext
-    else:
-        yield 2, "Expired since: %s" % render.timespan(-1.0 * expiration_time)
+            yield state, infotext
+        else:
+            yield 2, "Expired since: %s" % render.timespan(-1.0 * expiration_time)
 
 
 check_info["suseconnect"] = LegacyCheckDefinition(