From bffacb0aec96a99b2dc5f3166293c3a81da90bea Mon Sep 17 00:00:00 2001 From: Herman Ivanilov <ivanilovgerman@gmail.com> Date: Sun, 5 May 2024 19:07:10 +0200 Subject: [PATCH 1/2] Corrects minimum and maximum point calculation for candlestick chart --- .../Data/Implementations/Standard/CandleChartDataSet.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Charts/Data/Implementations/Standard/CandleChartDataSet.swift b/Source/Charts/Data/Implementations/Standard/CandleChartDataSet.swift index a860a3b91f..2f9bfcc3e7 100644 --- a/Source/Charts/Data/Implementations/Standard/CandleChartDataSet.swift +++ b/Source/Charts/Data/Implementations/Standard/CandleChartDataSet.swift @@ -45,9 +45,9 @@ open class CandleChartDataSet: LineScatterCandleRadarChartDataSet, CandleChartDa else { return } _yMin = Swift.min(e.low, _yMin) - _yMax = Swift.max(e.high, _yMin) + _yMax = Swift.max(e.high, _yMax) - _yMin = Swift.min(e.low, _yMax) + _yMin = Swift.min(e.low, _yMin) _yMax = Swift.max(e.high, _yMax) } From bf43db811afdfc3c4f4137aa87a72e309b2c2eba Mon Sep 17 00:00:00 2001 From: Herman Ivanilov <ivanilovgerman@gmail.com> Date: Mon, 6 May 2024 11:43:43 +0200 Subject: [PATCH 2/2] Fix min-max logic --- .../Data/Implementations/Standard/CandleChartDataSet.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Charts/Data/Implementations/Standard/CandleChartDataSet.swift b/Source/Charts/Data/Implementations/Standard/CandleChartDataSet.swift index 2f9bfcc3e7..1ddebbfd9d 100644 --- a/Source/Charts/Data/Implementations/Standard/CandleChartDataSet.swift +++ b/Source/Charts/Data/Implementations/Standard/CandleChartDataSet.swift @@ -44,10 +44,10 @@ open class CandleChartDataSet: LineScatterCandleRadarChartDataSet, CandleChartDa guard let e = e as? CandleChartDataEntry else { return } + _yMin = Swift.min(e.high, _yMin) _yMin = Swift.min(e.low, _yMin) - _yMax = Swift.max(e.high, _yMax) - _yMin = Swift.min(e.low, _yMin) + _yMax = Swift.max(e.low, _yMax) _yMax = Swift.max(e.high, _yMax) }