JOS 3 model

[FedericoTartarini]

@AkihisaNomoto I have noticed the following issues/improvements with JOS3.

• why we can pass both the operative temperature as well as the db and mean radiant temperature - remove to as input
• the inputs to the simulate function can be updated and renamed to improve readability and clarity. Why for example, we need to have two of them and we cannot combine them into one called duration in seconds or simulation_time to match the output? What is unclear to me is the difference from passing times=1 and dtime=60 versus times=60 and dtime=1
• in the documentation it is not described how to pass the metabolic rate as an input @AkihisaNomoto
• the unit of weight_loss_by_evap_and_res is strange since I would expect it to e the cumulative value over dtimes but the documentation says that this value is in g/s
• With a weight of 74 kg, the calculated skin temperature is outside the expected physiological range (initial is 33.17°C). In contrast, using a weight of 75 kg produces reasonable results (e.g., initial is 35.02°C). A 1 kg difference shouldn't theoretically result in such significant output variation.
• the conductance equation in contruction.py is not clear and it is not properly tested
• JOS3 options cannot be changed by the user and some are not well explained how they can be changed and what is their range
• PRE_SHIV should be better defined and referenced
• docstring add a statement about defaults
• added TODOs inline
• make sure the code in JOS3 Waseda and pythermalcomfort is the same
• fix evaporation in Waseda repository
• @yoshito-takahashi copy over the new changes in pythermalcomfort
• @AkihisaNomoto write tests
• cycle_time is not 100% clear what it is returning
• the model does not return the mean core body temperature.
• we should provide an easier way to access the results. For example, using a data class.
• we could potentially simplify the example and add a few more examples.
• in the documentation it is unclear why temperature can be passed when initialising the model as well as later.
• par seems to be a variable that can be passed when initialising the model but it is not. It can only be passed later when the model has already been initialised.
• I believe we should be combining all the functions in construct and thermoreg into one single file, I do not see why we need two.
• the anotione equation in JOS is incorrect. it was math.e ** (16.6536 - (4030.183 / (x + 235))) but it should be np.exp(16.6536 - 4030.183 / (x + 235)). I fixed, now the tests are not passing. We should check the JOS3 output.
• we do not need to return the pythermalcomfort version since that can be extracted from requirements.txt
• the documentation needs to be improved

[yoshito-takahashi]

hi