Skip to content

Commit ada6409

Browse files
committedFeb 7, 2023
Fix collections submit page test failure due to license validation
1 parent e1813a5 commit ada6409

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed
 

Diff for: ‎pages/collections.py

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ class CollectionSubmitPage(BaseCollectionPage):
3838
url_addition = 'submit'
3939

4040
identity = Locator(By.CSS_SELECTOR, 'div[data-test-collections-submit-sections]')
41+
loading_indicator = Locator(By.CSS_SELECTOR, '.ball-scale')
4142
project_selector = Locator(
4243
By.CSS_SELECTOR, 'span[class="ember-power-select-placeholder"]'
4344
)

Diff for: ‎tests/test_a11y_collections.py

+1-9
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import pytest
22
from selenium.common.exceptions import TimeoutException
3-
from selenium.webdriver.common.by import By
43
from selenium.webdriver.support import expected_conditions as EC
54
from selenium.webdriver.support.ui import WebDriverWait
65

@@ -80,17 +79,10 @@ def test_accessibility(
8079
submit_page = CollectionSubmitPage(driver, provider=provider)
8180
submit_page.goto()
8281
assert CollectionSubmitPage(driver, verify=True)
83-
# Continue process until Project contributors section is expanded before
84-
# calling axe
8582
submit_page.project_selector.click()
8683
submit_page.project_help_text.here_then_gone()
8784
submit_page.project_selector_project.click()
88-
submit_page.project_metadata_save.click()
89-
WebDriverWait(driver, 5).until(
90-
EC.visibility_of_element_located(
91-
(By.CSS_SELECTOR, '[data-test-project-contributors-list-item-name]')
92-
)
93-
)
85+
submit_page.loading_indicator.here_then_gone()
9486
a11y.run_axe(
9587
driver,
9688
session,

0 commit comments

Comments
 (0)
Please sign in to comment.